From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 9D1A65A026F for ; Thu, 21 Mar 2024 02:33:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1710984809; bh=azHBTrAiH1nR7U0oWiRlAJQoWEq/gX/GEsxZoF9AuO0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MXSWzOafki9yo/402yQhIRUML8N/LiHUvm3tqpbYK2mqd8UlbcvyQ9KRc1R7KkkFB uxnvrL9GaWmi5Ey7RVbJWK74EikRc2o+n926f7etrT8TAIFkS/Phs/a+wxq22RBQI8 81u2vUghxei1c65gG3hyRTL57ueawoAyQ+ypR84OyXdwoXe4iNejZSXsHQVKwOU+kP 3hMka82qtwC5Zc5KYyOfp0ZzXUEWzmWUWjJb3Yl70Uhsv9FWKKTFi+O4nzaVOLbJxF 4+Ag76aOG8IfQVtwarDJRetUQKtxwIwpG8cPOpMXCvgA2sUjI0dmoEKU6rMCROFSBA DgZTT5AKL8htA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4V0Sf13t8Zz4wc4; Thu, 21 Mar 2024 12:33:29 +1100 (AEDT) Date: Thu, 21 Mar 2024 12:26:59 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [RFC v3] tcp: Replace TCP buffer structure by an iovec array Message-ID: References: <20240320163146.1918122-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zzcCFCmKayAsU2cz" Content-Disposition: inline In-Reply-To: <20240320163146.1918122-1-lvivier@redhat.com> Message-ID-Hash: QJ5IRLIY73FJ4ZVRAMPQ3ZNGI2UMIDGV X-Message-ID-Hash: QJ5IRLIY73FJ4ZVRAMPQ3ZNGI2UMIDGV X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --zzcCFCmKayAsU2cz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 20, 2024 at 05:31:46PM +0100, Laurent Vivier wrote: > To be able to provide pointers to TCP headers and IP headers without > worrying about alignment in the structure, split the structure into > several arrays and point to each part of the frame using an iovec array. >=20 > Using iovec also allows us to simply ignore the first entry when the > vnet length header is not needed. >=20 > Signed-off-by: Laurent Vivier [snip] > +static_assert(MSS4 <=3D sizeof(tcp4_payload[0].data)); This generates a clang-tidy warning, because apparently the C11 version of static_assert() requires a message - making it optional is a C2x extension. Laurent, I know you're having trouble getting the full testsuite to run (but some ideas on that later today, I hope). But could you please add a "make cppcheck" and "make clang-tidy" to your pre-post routine. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --zzcCFCmKayAsU2cz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmX7jOIACgkQzQJF27ox 2GcR6w//bF9rFBtipX+4vK/vwVIZFjbd6VfWsM1o0EsHsFc8+aa4i5TSUTBYTwj3 pyICVey2umLcdbNGfMcC7+jI3w4/k0fXBbTADi3Ob2BBY2wVrCPwL5k/lORAtQca ofo/7sSpyLkXG8FuwQnKiJSRuy0U7eEsCXqwXaJRL7rvkvw42wlEthmBNb+RXoaU uWsICzGb/28/LEyDbZf1D5j2f5L7mM3Vhpni2WZFWNQL5klLhWb3M4M4b0JrB3V7 WagR5cyUO1eQnylFSdFCFGsZzTUDmsDtlJt/hYGrOmlwRniLbDoKigAm8adSQ19D ebvW80cYGYByPs5ED4tzGb+vF15MyYE+ZskpFnBIlg2dtUuE8OLPIP2/uyPFSqy9 ULbaRQ61w9fXWuW/1lBZHGtjcI/mlH6YTjlYJ72T5TGm8GDPLY49RVSqjn8jhNLa YxVAhZuet/O+IhF8x/i3UhBxAWto90jfyVEHyIVgWQjjIjRs0zA8LUX+7DBud9l3 A5EpFw3opOL9OJOg/nyloqujxxJzr3fXFH4ibuw9GPUYg6tTO885r83OngsBB2OB zMSd9Q34jpTJH4JIbCc6Yvu3aXqKuCgUTK4WAL4SUPk/I4CmHkvteAOk3CC5fLzv AKnTZsH645g65t2lKhVBTA9dB+0J77LA1FAKJL+Y+sMY7KCKmfA= =8RDw -----END PGP SIGNATURE----- --zzcCFCmKayAsU2cz--