From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id BBB515A0272 for ; Thu, 21 Mar 2024 11:56:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1711018562; bh=HSzseQ0561yeYMyDzN0Bo3iY5yhHhKq+R15dNd6jyGY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EGRQv70dmLc5zCd9YPo3NQji8/OOxJlq6Xi07WZ37sjnEpYa2xiqcXrYTUJsPRyln 9ILsp3zaZAAQwZO6366+IyQW/qt7OkFuA+ewr7dJEuonynQY4tiQ/+0CK9QHgk/BSN nagKuEUjRrdcwklGAwa9tVowg75pUZBxo0pLlgtL7ULz+N6lK1p8Us3iB9rOb4FK7V DypSHUa5UxNAm2Uw1wccKR6NcFARXIUS1yca8wllrqZPwRycn2r9CSdsc8+LRyyUol dE1a0j0jJZU9g4nrtAF9L3t7bG5dko3Y4ubKv87GXKWoOdNEUoDmvdO5TaeWx7Mb4W g/BkNqaHVyekA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4V0j7614K7z4wcQ; Thu, 21 Mar 2024 21:56:02 +1100 (AEDT) Date: Thu, 21 Mar 2024 21:55:55 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [RFC v3] tcp: Replace TCP buffer structure by an iovec array Message-ID: References: <20240320163146.1918122-1-lvivier@redhat.com> <6d0c5777-ed50-4e99-96cb-35aa38d0e129@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZywDIqL8K+aXf9SH" Content-Disposition: inline In-Reply-To: <6d0c5777-ed50-4e99-96cb-35aa38d0e129@redhat.com> Message-ID-Hash: COP5BGRK5E6A5XJNGKBXC6Z424UOBIHM X-Message-ID-Hash: COP5BGRK5E6A5XJNGKBXC6Z424UOBIHM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ZywDIqL8K+aXf9SH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 21, 2024 at 09:26:58AM +0100, Laurent Vivier wrote: > On 3/21/24 02:26, David Gibson wrote: > > On Wed, Mar 20, 2024 at 05:31:46PM +0100, Laurent Vivier wrote: > > > To be able to provide pointers to TCP headers and IP headers without > > > worrying about alignment in the structure, split the structure into > > > several arrays and point to each part of the frame using an iovec arr= ay. > > >=20 > > > Using iovec also allows us to simply ignore the first entry when the > > > vnet length header is not needed. > > >=20 > > > Signed-off-by: Laurent Vivier > >=20 > > [snip] > > > +static_assert(MSS4 <=3D sizeof(tcp4_payload[0].data)); > >=20 > > This generates a clang-tidy warning, because apparently the C11 > > version of static_assert() requires a message - making it optional is > > a C2x extension. > >=20 > > Laurent, I know you're having trouble getting the full testsuite to > > run (but some ideas on that later today, I hope). But could you > > please add a "make cppcheck" and "make clang-tidy" to your pre-post > > routine. > >=20 >=20 > I'll do. > Thank you to have checked that. > Are there any other commands to run before to send? > Something like scripts/chekpatch.pl we have in QEMU? >=20 > I have always the same problem with the test suite, even after a "make > realclean" in test (see attachment) > How to debug? Huh. Guest kernel can't find root. That's not a fault I was expecting (and alas, won't be helped by the patch I have in the works). What's really weird is I don't see any signs of loading the initrd before that failure, and with the mbuto images we're using we should never *leave* the initrd. Which kind of makes sense - if it's not seeing the initrd, then there is indeed no root to mount. Can you gran the full qemu command line it's trying to use? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ZywDIqL8K+aXf9SH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmX8EhcACgkQzQJF27ox 2GfYLxAAgzBAq3w3nL6qLBgwMhQt2p4vX5a2YRJ3uIfHr2HOSabDCkoTEi88ktVD mKXVw6u+h18ox9bUs+6jQGhekwRs7k3ZypZ/2rjqZKmuQCdxrd8FhE9v5PcylZhi sMaBIO7Sgd/LSA+yLi6YcMw2QEJT8pA4XpMFziMjCoOQn7Q0QjwftFCEIgEx3D38 WQm35N9h5A/YPcPBeYbtlzg2YyJx2A9MEWqEN1GJZoplpKR9XQBEXNiz+ALKMC28 ekZujAhsZl/iPYzs4DZGKufqtmC7hRgkwuG5tkzT1bnhm5sMEGqIc8r4sazQJm8I nZJk/nPhIPtMvTwnQSz5F2XU/SkEKIHcxh6xWRN+2Ax9muLQYJ9hE9H98IJRlgbJ m/EV0TYDDILT3/vxrgEocF6EM/Ap0Sw0CVpd8zxBNPlxKpQEhPAqNSDcngl9MDog xJ/bcASgGW4wzpnLOwG19jBSw9K2g4ME3GxmYDFn4aDalPECM2+kn9Uoq4EuUHmB cYTT8It3TN8c7GsTqkN4dZNI3Q7lU/eOYRDRLyrYQDO1QvCmR9xYDW+UcNsh579F zlMFu7Fr20T7kGgANUC+huGc1VPFrf3NWG6Vvdv1bptNfaYOrcy1AOvh/eR/NMcE /wD8mDbsOfh+TeYWKTxSu2s0LjyKy7eX52OjNMCdloJUSk9BVfc= =re32 -----END PGP SIGNATURE----- --ZywDIqL8K+aXf9SH--