From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id F37F95A0277 for ; Sat, 6 Apr 2024 05:11:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1712373076; bh=0pyP2Jt2W39UEtDqr4aMzedpKbhyEgLiSbRFe8x/uYU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ipDnKoPSL70tAkOzUyYZRHF+ws+mH2ja629G7I3tsaWVxdi71036KxA4OOfjDo5+7 95cwSxNYl6B2XrMF+GYXEFwO0tFD+zK3hRxHN4xgGAs0qx7bOfjmcrzOKA8iUG3tsY WAW85gaPMGKzNtMjrlgPjMY2BwmBUS7qUWnUo5XwQqlVb8BmKuzPTgnWmFKpa641fb ST0907ZSqWu7xUW1S7pnnPGwVt0AYxjNvayk2gxQZBNIfREuKrWLqC6eYetcHTYEra mBzBCiVOdTgwkIhq4WPwf58LBc97u+QY4Syr5tOeppq/bMsSehmNhLlt29k4u28mbW naOweZE4clrng== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4VBL3S5FQcz4wyS; Sat, 6 Apr 2024 14:11:16 +1100 (AEDT) Date: Sat, 6 Apr 2024 14:02:58 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/4] Remove stale archivemount support Message-ID: References: <20240322022739.2746102-1-david@gibson.dropbear.id.au> <20240322022739.2746102-3-david@gibson.dropbear.id.au> <20240405200921.0a1f0318@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3ONf8LUY85mFRD0Z" Content-Disposition: inline In-Reply-To: <20240405200921.0a1f0318@elisabeth> Message-ID-Hash: KH5FTEPRDXOUJD3T5DPTIDYBQNJCGFED X-Message-ID-Hash: KH5FTEPRDXOUJD3T5DPTIDYBQNJCGFED X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: lvivier@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3ONf8LUY85mFRD0Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 05, 2024 at 08:09:32PM +0200, Stefano Brivio wrote: > On Fri, 22 Mar 2024 13:27:37 +1100 > David Gibson wrote: >=20 > > mbuto has two ways of building the initramfs. One is the typical appro= ach > > of staging its contents in a temporary directory, then building the > > initramfs with cpio. The other is to create an empty initramfs, mount > > it with archivemount, and copy things into the mounted archive. > >=20 > > However, the archivemount approach is broken. I'm not entirely sure wh= y, > > but it appears not to properly unmount the archive and retrieve the fin= al. > > filled version. The upshot is that if archivemount is installed, then > > mbuto generates an empty, gzip-compressed initramfs instead of whatever= it > > was supposed to. It looks like this has bitrotted from some earlier > > working version. > >=20 > > The archivemount approach is not necessary, and honestly a pretty stran= ge > > and roundabout way of building the initramfs. Remove it. >=20 > There were two reasons behind that: first off, I mistakenly assumed > that the kernel could see changes made to the initramfs after boot. Yeah, that was never going to work. > Second, it was actually convenient for developing this tool as I could > just make directories and copies in half-working images. I also had > half a mind about some usage with QEMU rebooting the guest, and the > initramfs would change across reboots without having to call mbuto > again, for bisections or suchlike. That's not really dependent on using archivemount in any case. If qemu re-reads the initrd on each boot, then you can still do this by rebuilding the image between boots (which is all that archivemount would do anyway). If qemu doesn't re-read it, then this won't work even if you are using archivemount. > But sure, it turned out to be quite complicated to maintain, and it > looks like it has been broken on Fedora for a while now (probably due > to differences between fakeroot and fakeroot-ng I didn't take into > account), so, with some regrets, I'm fine to drop this now. >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --3ONf8LUY85mFRD0Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmYQu1MACgkQzQJF27ox 2GfYQw/+OJaZNZEFlYHS/63D7GXiNXFjLwn1Gn7O+6Tw5Ksx3nukdUMuF0qQaCX6 jo3ZdR7k8qlpAQ7RZaryQ9QqU6YuLAnGNvL5fos5D27wsVK2FSoqk8Ztc+jEPRpb Yh6pmmxB3IUAm2XeKI671QAReAddHrjtCCQvcAgtDKM/kLCUQqRmWznIB8lgmuoo 12iqKE6/EgHvbbph5aXNlCO6iYHzoqK2JIQnafjWON/4+ctmgE8DZqwqn22nzYdm 0+Mrgn+VSeJTsikoK8Utzi6ewtf61Y3gPAXOze2znmrCQdnB31ZIN320/BX29Ggm q/MH0r9zqTOqVWYABUcD1Zm21v2c5LCE70Y7cSKXuJaPF6EUCuU4Iklh1xYo8rnj wmzNEyKA4rsB+z7ujfsM1ers4eshHQTbtPd2Pn9YeRpRt6D7KVf59z0kl6D3Xfho kRg2c3W/WGyUwjNr8fjndFt0d2gXnn5aTWfFrlqeuOfQklqWuKKiEdfBzvgsQJ1l sMbbgBewiSpmtUVG1URkhdL+peGJn5Fx5Oji+sdgChK3Oha775LIXlqRZpAf/jZb vZBNv1DoYoaRAsTNWSTasf+HIShq8rnE9c1dzh0zb+v1lloMrgDZX9POGOtMDj9h iiBIDV21WZNMnmfh5ZywQFqncy1+DneiI8ivWqJsSAQGOpiE6qc= =0lDv -----END PGP SIGNATURE----- --3ONf8LUY85mFRD0Z--