From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id DF0AE5A0276 for ; Fri, 12 Apr 2024 05:43:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1712893408; bh=F59HwwxQRB/Wv3q8Z/rRFiyxeupexYd0YnhEoFGs6VE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C6W+vpVzfniPXSkcn1uhZQXGsngaukr9VZkzDiLYX6tmPxYjvVSnzhu8YBouGSo7O mJ1+M0al7Bs3Eg8KdimUF+ooFPj88hMsib5VaJnA575CQp5ODVXzGeAs1/HETWOnLD wYoySneiDIAba/B0wWeZr1ydwkbF9r+iWy/nrLh1N/84s2GfNX711VG4mQMgITyG6y 1+2NmOrh31kCRqiF0GlUfqy4OnVccZePR7WSvmPCl9CJKx5dwbl5tGGnVIJLGBFiPt 4t51z9jOotkdG5pIVKbWcrgcrnvp5lUGrJKysJ861MsyMQ/5NZsEJFVdcpXhI6PnlK JZgzQdBj+fF3w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4VG2Tr6wFwz4wqM; Fri, 12 Apr 2024 13:43:28 +1000 (AEST) Date: Fri, 12 Apr 2024 12:00:53 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] conf: We're interested in the MAC address, not in the MAC itself Message-ID: References: <20240411221800.548153-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F7pg5RMlTuMKhx4p" Content-Disposition: inline In-Reply-To: <20240411221800.548153-1-sbrivio@redhat.com> Message-ID-Hash: M2XRWUO3TDYOXC7CH2HNVP35KWA3GDNE X-Message-ID-Hash: M2XRWUO3TDYOXC7CH2HNVP35KWA3GDNE X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --F7pg5RMlTuMKhx4p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 12, 2024 at 12:18:00AM +0200, Stefano Brivio wrote: > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > conf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/conf.c b/conf.c > index 9e0318a..90d3436 100644 > --- a/conf.c > +++ b/conf.c > @@ -625,7 +625,7 @@ static unsigned int conf_ip4(unsigned int ifi, > int rc =3D nl_link_get_mac(nl_sock, ifi, mac); > if (rc < 0) { > char ifname[IFNAMSIZ]; > - err("Couldn't discover MAC for %s: %s", > + err("Couldn't discover MAC address for %s: %s", > if_indextoname(ifi, ifname), strerror(-rc)); > return 0; > } > @@ -684,7 +684,7 @@ static unsigned int conf_ip6(unsigned int ifi, > rc =3D nl_link_get_mac(nl_sock, ifi, mac); > if (rc < 0) { > char ifname[IFNAMSIZ]; > - err("Couldn't discover MAC for %s: %s", > + err("Couldn't discover MAC address for %s: %s", > if_indextoname(ifi, ifname), strerror(-rc)); > return 0; > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --F7pg5RMlTuMKhx4p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmYYldQACgkQzQJF27ox 2GcHIQ/+PWvq/XI9lYq080Iz9ISwBT22n6b7HOXOoZPB5Wq+ewC6dGf5XIUCmxjd d7oMah0WwtgzL02naPsQ7hwpKvg+/IeeaWybGyptWpHMlPtIJftcRg0dD15ubitB gQdDVsFzePrqzedompHdQPprzBDn7HeHWhSPB9QZkNqxKP18qafQGdo1VNSQkyQx yumlhspcMesq3kVmrSQSWPOafV4m94FgJ7U0tT3EaPu1NmzfQM6cjIhxvaeQEhjO /Y+MNA67MYlRONviXt0AhefyA4hjzwiD9umMrAyfKd1whbm0Ygc6Lx6WvhGl8vdE skrOUxim0ZNMwy2Sy/KxSJyYZzoCpRJgLehv2XCLYqa557XCQh2o7D85DgnOd1YZ 1rcal9bcWpRFbFHgsHHZeFxocunEdZaeSbnNqipO1dt8+T2S732972LuUNkzQCCt CaEH8Jp7YxjknAEtnLgKZzAeREFZVYvY3qgH+WtixbdBY7gzu8BBPMt7t/8pxHzQ ZEnPeBoiaLNSpLv61w1ggCmEaGt0qS2TQj4/5jvPWQr5Btqk1xYSu/basOxdlIML zN1EZCvqCxge6c9Q7lDQZMM650XCgqFYy2tw3EbDrGWiOvn3EhS0TebTP96qui6T kZTfKLmWyw/6gj43whTLsNJR/iIJovEoQ82UeDROGCEImtkudeI= =h6tU -----END PGP SIGNATURE----- --F7pg5RMlTuMKhx4p--