* [PATCH] conf: We're interested in the MAC address, not in the MAC itself
@ 2024-04-11 22:18 Stefano Brivio
2024-04-12 2:00 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2024-04-11 22:18 UTC (permalink / raw)
To: passt-dev
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/conf.c b/conf.c
index 9e0318a..90d3436 100644
--- a/conf.c
+++ b/conf.c
@@ -625,7 +625,7 @@ static unsigned int conf_ip4(unsigned int ifi,
int rc = nl_link_get_mac(nl_sock, ifi, mac);
if (rc < 0) {
char ifname[IFNAMSIZ];
- err("Couldn't discover MAC for %s: %s",
+ err("Couldn't discover MAC address for %s: %s",
if_indextoname(ifi, ifname), strerror(-rc));
return 0;
}
@@ -684,7 +684,7 @@ static unsigned int conf_ip6(unsigned int ifi,
rc = nl_link_get_mac(nl_sock, ifi, mac);
if (rc < 0) {
char ifname[IFNAMSIZ];
- err("Couldn't discover MAC for %s: %s",
+ err("Couldn't discover MAC address for %s: %s",
if_indextoname(ifi, ifname), strerror(-rc));
return 0;
}
--
@@ -625,7 +625,7 @@ static unsigned int conf_ip4(unsigned int ifi,
int rc = nl_link_get_mac(nl_sock, ifi, mac);
if (rc < 0) {
char ifname[IFNAMSIZ];
- err("Couldn't discover MAC for %s: %s",
+ err("Couldn't discover MAC address for %s: %s",
if_indextoname(ifi, ifname), strerror(-rc));
return 0;
}
@@ -684,7 +684,7 @@ static unsigned int conf_ip6(unsigned int ifi,
rc = nl_link_get_mac(nl_sock, ifi, mac);
if (rc < 0) {
char ifname[IFNAMSIZ];
- err("Couldn't discover MAC for %s: %s",
+ err("Couldn't discover MAC address for %s: %s",
if_indextoname(ifi, ifname), strerror(-rc));
return 0;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] conf: We're interested in the MAC address, not in the MAC itself
2024-04-11 22:18 [PATCH] conf: We're interested in the MAC address, not in the MAC itself Stefano Brivio
@ 2024-04-12 2:00 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2024-04-12 2:00 UTC (permalink / raw)
To: Stefano Brivio; +Cc: passt-dev
[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]
On Fri, Apr 12, 2024 at 12:18:00AM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> conf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/conf.c b/conf.c
> index 9e0318a..90d3436 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -625,7 +625,7 @@ static unsigned int conf_ip4(unsigned int ifi,
> int rc = nl_link_get_mac(nl_sock, ifi, mac);
> if (rc < 0) {
> char ifname[IFNAMSIZ];
> - err("Couldn't discover MAC for %s: %s",
> + err("Couldn't discover MAC address for %s: %s",
> if_indextoname(ifi, ifname), strerror(-rc));
> return 0;
> }
> @@ -684,7 +684,7 @@ static unsigned int conf_ip6(unsigned int ifi,
> rc = nl_link_get_mac(nl_sock, ifi, mac);
> if (rc < 0) {
> char ifname[IFNAMSIZ];
> - err("Couldn't discover MAC for %s: %s",
> + err("Couldn't discover MAC address for %s: %s",
> if_indextoname(ifi, ifname), strerror(-rc));
> return 0;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-12 3:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-11 22:18 [PATCH] conf: We're interested in the MAC address, not in the MAC itself Stefano Brivio
2024-04-12 2:00 ` David Gibson
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).