From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH 5/7] tap, tcp: (Re-)abstract TAP specific header handling
Date: Wed, 1 May 2024 10:06:33 +1000 [thread overview]
Message-ID: <ZjGHiTI3P4ApC-Pe@zatzit> (raw)
In-Reply-To: <20240430204718.520f3b5b@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]
On Tue, Apr 30, 2024 at 08:47:18PM +0200, Stefano Brivio wrote:
> On Mon, 29 Apr 2024 17:09:31 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > Recent changes to the TCP code (reworking of the buffer handling) have
> > meant that it now (again) deals explicitly with the MODE_PASST specific
> > vnet_len field, instead of using the (partial) abstractions provided by the
> > tap layer.
> >
> > The abstractions we had don't work for the new TCP structure, so make some
> > new ones that do: tap_hdr_iov() which constructs an iovec suitable for
> > containing (just) the TAP specific header and tap_hdr_update() which
> > updates it as necessary per-packet.
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> > tap.h | 27 +++++++++++++++++++++++++++
> > tcp.c | 40 +++++++++++++++-------------------------
> > 2 files changed, 42 insertions(+), 25 deletions(-)
> >
> > diff --git a/tap.h b/tap.h
> > index dbc23b31..75aa3f03 100644
> > --- a/tap.h
> > +++ b/tap.h
> > @@ -16,6 +16,33 @@ struct tap_hdr {
> > uint32_t vnet_len;
> > } __attribute__((packed));
> >
> > +/**
> > + * tap_hdr_iov() - struct iovec for a tap header
> > + * @c: Execution context
> > + * @taph: Pointer to tap specific header buffer
> > + *
> > + * Returns: A struct iovec covering the correct portion of @taph to use as the
> > + * TAP specific header in the current configuration.
>
> Nit: s/TAP/tap/ (not an acronym).
Fixed, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-05-01 0:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 7:09 [PATCH 0/7] Small improvements to IOV handling David Gibson
2024-04-29 7:09 ` [PATCH 1/7] checksum: Use proto_ipv6_header_psum() for ICMPv6 as well David Gibson
2024-04-29 7:09 ` [PATCH 2/7] tap: Split tap specific and L2 (ethernet) headers David Gibson
2024-04-30 18:46 ` Stefano Brivio
2024-04-30 23:53 ` David Gibson
2024-04-29 7:09 ` [PATCH 3/7] treewide: Standardise variable names for various packet lengths David Gibson
2024-04-30 18:46 ` Stefano Brivio
2024-05-01 0:05 ` David Gibson
2024-04-29 7:09 ` [PATCH 4/7] tcp: Simplify packet length calculation when preparing headers David Gibson
2024-04-29 7:09 ` [PATCH 5/7] tap, tcp: (Re-)abstract TAP specific header handling David Gibson
2024-04-30 18:47 ` Stefano Brivio
2024-05-01 0:06 ` David Gibson [this message]
2024-04-29 7:09 ` [PATCH 6/7] iov: Helper macro to construct iovs covering existing variables or fields David Gibson
2024-04-30 18:47 ` Stefano Brivio
2024-05-01 0:09 ` David Gibson
2024-04-29 7:09 ` [PATCH 7/7] tcp: Update tap specific header too in tcp_fill_headers[46]() David Gibson
2024-04-30 18:48 ` Stefano Brivio
2024-05-01 0:10 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjGHiTI3P4ApC-Pe@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).