From: David Gibson <david@gibson.dropbear.id.au>
To: lemmi <lemmi@nerd2nerd.org>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] passt.c: explicitly include libgen.h for basename
Date: Mon, 13 May 2024 11:36:10 +1000 [thread overview]
Message-ID: <ZkFuil9P4jglf-GB@zatzit> (raw)
In-Reply-To: <20240511154555.22176-1-lemmi@nerd2nerd.org>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Sat, May 11, 2024 at 05:45:42PM +0200, lemmi wrote:
> fixes implicit declaration warning on musl
>
> Signed-off-by: lemmi <lemmi@nerd2nerd.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> passt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/passt.c b/passt.c
> index e93b6be..771b8a7 100644
> --- a/passt.c
> +++ b/passt.c
> @@ -35,6 +35,7 @@
> #include <syslog.h>
> #include <sys/prctl.h>
> #include <netinet/if_ether.h>
> +#include <libgen.h>
> #ifdef HAS_GETRANDOM
> #include <sys/random.h>
> #endif
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-05-13 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 15:45 [PATCH] passt.c: explicitly include libgen.h for basename lemmi
2024-05-13 1:36 ` David Gibson [this message]
2024-05-13 21:36 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkFuil9P4jglf-GB@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=lemmi@nerd2nerd.org \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).