From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 30AC95A02C2 for ; Tue, 14 May 2024 02:18:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1715645925; bh=xwdJ0bYxydHph9JSzOfzsOd591gvh5TRf89t5N/cP/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yd+t4Y2yoqVNRyXIsmGUJILymmKLjPIBknkEf1F31ywbyawglNniivOxsDWm6oh58 mb1RretmCSr5BlEuoSnmnJJcp7jsTayGs2clfKQtsiyQ1Oa3Cc/Y19DEareJSiq+FN F1oCLT+JhaZUFS3jMVNNeIv9C3ma4If507wqyX8KgXvqo2F7FwxFYMLvqr42BAmq4r B4oRMFSLWibiRu/QTINQWKxB4zgWc/cKryZlbPTkw7OXnyrWxb4BjTTaHNmb4k9hj7 Cx0Gt8eHFldmcIDfAFru1QX++jtCUnTcxQDsWiuHbtbp4se/PDb0qQfiYub2y5njnI 4FAoK/teU8i0w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4VdcQs5b4Vz4wcl; Tue, 14 May 2024 10:18:45 +1000 (AEST) Date: Tue, 14 May 2024 10:18:34 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v4 04/16] tcp: Obtain guest address from flowside Message-ID: References: <20240503011135.2924437-1-david@gibson.dropbear.id.au> <20240503011135.2924437-5-david@gibson.dropbear.id.au> <20240513200743.4892b63b@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6d7dh0wDSKWAwHZH" Content-Disposition: inline In-Reply-To: <20240513200743.4892b63b@elisabeth> Message-ID-Hash: 2ZLGIV3EBNG3W6JSGEBSXECDPG4N4D5C X-Message-ID-Hash: 2ZLGIV3EBNG3W6JSGEBSXECDPG4N4D5C X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --6d7dh0wDSKWAwHZH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 13, 2024 at 08:07:43PM +0200, Stefano Brivio wrote: > On Fri, 3 May 2024 11:11:23 +1000 > David Gibson wrote: >=20 > > Currently we always deliver inbound TCP packets to the guest's most > > recent observed IP address. This has the odd side effect that if the > > guest changes its IP address with active TCP connections we might > > deliver packets from old connections to the new address. That won't > > work; it will will probably result in an RST from the guest. Worse, >=20 > s/will will/will/ Fixed. > ...if I recall correctly, that was actually working, as long as we > don't swap link-local with global unicast addresses (hence those > conditions sprinkled all over the place). Um.. I don't see how that's possible. Linux - and I imagine any peer - will index TCP connections by both endpoint addresses, so if we deliver packets from one connection to a different address, the peer won't recognize them as belonging to the old connection. > But it doesn't matter in any case, this is surely the way forward. >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --6d7dh0wDSKWAwHZH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmZCrdkACgkQzQJF27ox 2GdClg/8CM3dz+lywboUX3scaAnAyhhrrKeVRDCVkg1oDUAayMH8FJWm+zXUKC0x zM8/64ScPWyDFyaVGEEGr9qEZ2nHOcZ+12O5ngMra2QHVlcIrutA1WY08yIWVwOg Jf0+bdXNaNPYXhnrDJRVdZygoLUAanNj8ix2qUa79RnHLoGvWJgpSC7pGmGYqV7n 0ndjx+QFNKxjW3YRFTOp/Tvs2rCGtMMu/eA5eMbRJPt/odH9VjpGCAoPsWePot0A IZv/kv/F4Ro30sLtyujfn9WenhAEgpO3HptBr+BdgJis/EMwGjDlqTVWzcgC4Nfd J1nNroc/VfVPH7L6D6G5K6cXQUk4GTW/5jue274ARfmB0Wsbl0COp8vvqOMstnSZ KGBcq/t7/juy+owzarvWHd7ueKlEy11m0s/n8ub0Sofw1fC7PE4BgYt5d2Gl5gbs gjFOij0+u2b2aMVrejZ4ulGuwnUP3WJF52TXXTIUEKJYDrGvC2z7IH/UFdskgl6C n4WNuMGXG2+LEQujZnfERmICgtdsLpSx7vZ5rCfoitVXdnD+LvPTcThgAeeMfqdS A84AnHfmzqOtbD/z7XEXbCTU4wj3Q+g0c6vJHV2Umt3g2c3kVbPhEREpNgIDMtS5 qBNhDFRgb3c4lS53WZmcCIBEOeTE7HHKtuQMqs4xFKHz724IQfM= =5H8l -----END PGP SIGNATURE----- --6d7dh0wDSKWAwHZH--