From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id B10745A0307 for ; Mon, 03 Jun 2024 06:04:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1717387487; bh=RnwJI6IN/u6+VMfOS9PpQ2OxQ0UwyYO2gD0YGKTQB+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D2M0zvlmkViucvuKLQOS4JpBGD6++bw/OmGyKLazSjoZ8w3kTYw1bXPAW5Wu3ffCL evXn267uJFpbQxScCh1wWLLw+AxVejxOCOnLZPLT2rr/LgJoL2INeQyrAoM0mrFFcN OWZZz7ZDwF58qwnth243pDgBQSGpvn+bp9Mopf3eMbPjw34TDOkMV1K0uPuMRk52JP spkCMGz5cQpWObDROS3mwxc1w2JvbY6XJX7tyLUZzFzzV67ZFnnESpQaYEaJeioEf9 lk5xtmOzSFAjeCiSRFzM46ryJULLCEoRDYSLgx9a0OGDC2T4f3iKjfUzwjFfRm2zX1 BFZrc7oTNIlIQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Vt0VR6763z4wx6; Mon, 3 Jun 2024 14:04:47 +1000 (AEST) Date: Mon, 3 Jun 2024 14:02:49 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v4 06/10] udp: rename udp_sock_handler() to udp_buf_sock_handler() Message-ID: References: <20240531142344.1420034-1-lvivier@redhat.com> <20240531142344.1420034-7-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/YmWBAMtdKtMmxyb" Content-Disposition: inline In-Reply-To: <20240531142344.1420034-7-lvivier@redhat.com> Message-ID-Hash: EUS2RYHUK6BNRDYOT6PKSE6AH7T6ZK46 X-Message-ID-Hash: EUS2RYHUK6BNRDYOT6PKSE6AH7T6ZK46 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --/YmWBAMtdKtMmxyb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 31, 2024 at 04:23:40PM +0200, Laurent Vivier wrote: > We are going to introduce a variant of the function to use > vhost-user buffers rather than passt internal buffers. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > passt.c | 2 +- > udp.c | 6 +++--- > udp.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/passt.c b/passt.c > index a8c4cd3f8820..69a59f1e9b6d 100644 > --- a/passt.c > +++ b/passt.c > @@ -365,7 +365,7 @@ loop: > tcp_timer_handler(&c, ref); > break; > case EPOLL_TYPE_UDP: > - udp_sock_handler(&c, ref, eventmask, &now); > + udp_buf_sock_handler(&c, ref, eventmask, &now); > break; > case EPOLL_TYPE_PING: > icmp_sock_handler(&c, ref); > diff --git a/udp.c b/udp.c > index 4295d48046a6..a13013901e26 100644 > --- a/udp.c > +++ b/udp.c > @@ -729,7 +729,7 @@ static void udp_tap_send(const struct ctx *c, > } > =20 > /** > - * udp_sock_handler() - Handle new data from socket > + * udp_buf_sock_handler() - Handle new data from socket > * @c: Execution context > * @ref: epoll reference > * @events: epoll events bitmap > @@ -737,8 +737,8 @@ static void udp_tap_send(const struct ctx *c, > * > * #syscalls recvmmsg > */ > -void udp_sock_handler(const struct ctx *c, union epoll_ref ref, uint32_t= events, > - const struct timespec *now) > +void udp_buf_sock_handler(const struct ctx *c, union epoll_ref ref, uint= 32_t events, > + const struct timespec *now) > { > /* For not entirely clear reasons (data locality?) pasta gets > * better throughput if we receive tap datagrams one at a > diff --git a/udp.h b/udp.h > index 9976b6231f1c..5865def20856 100644 > --- a/udp.h > +++ b/udp.h > @@ -9,7 +9,7 @@ > #define UDP_TIMER_INTERVAL 1000 /* ms */ > =20 > void udp_portmap_clear(void); > -void udp_sock_handler(const struct ctx *c, union epoll_ref ref, uint32_t= events, > +void udp_buf_sock_handler(const struct ctx *c, union epoll_ref ref, uint= 32_t events, > const struct timespec *now); > int udp_tap_handler(struct ctx *c, uint8_t pif, sa_family_t af, > const void *saddr, const void *daddr, --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --/YmWBAMtdKtMmxyb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmZdQGgACgkQzQJF27ox 2GecxhAAmpleD04nKsU7UGqr6Wp9dDqHOMJdRM3VvvZt8R+VXHzLXmHLZh5F2cMj c4mUu2rLYOyszq2Sn77rlfQD+CAOZkzZ6d9UFAkZ/A8XvahD4BTtwXznjr6Ujbiq og3mLv+0fjm3Z1aCwqwxRkRwnsQDFc+tzrYst3qbJW9VFyN2dLe9wazL90nxPdVs 5C9lqRnIWDtUgOdwLEVsDn29zyzYJVU+/ArsBX3FPOHg+f1RCZ79hDdwK0DW6SaR nK6w4A9C4VA7O0z/LsgDV8+5AMdfB7g0QUBtcV9aqSTh9Z55bm0BU/lCSJuT4bS7 PaZMttRUHnLNXsUYlVt8BDeVlO1CDbJPgzaEMrOW6pfA7D2d+lQ97BqjkMzCwyCg mt5pPbbMzDKlHMsRzidicnd2vzEmBnePugZwpCTzcevxEAXwJjTwjRt0rRplc+2Q pRWaG/9n6S6Hd9uQWTPrPYNxSyJdO1WREchFbVfnxv42M6p0vAzTvAmtICD77QCA xc5CP/e+BAa++gyYy9yXDJyZsjTemtYQ/np6slJjlq/OYFK54x2udidvYvKj97LP 8heoyclbrlFQPWRI/qHIcLTtKeGLbZVv6fmSnUN3IBlCJgit/gtsgkd82fySY4li J+2upVWXi/W3VFxVzK/0fR2QwbArsYF973wx3DAzkB475Qvmidw= =NXwM -----END PGP SIGNATURE----- --/YmWBAMtdKtMmxyb--