From: David Gibson <david@gibson.dropbear.id.au>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v4 10/10] tap: use in->buf_size rather than sizeof(pkt_buf)
Date: Mon, 3 Jun 2024 14:20:35 +1000 [thread overview]
Message-ID: <Zl1Ekzttdq33hYtw@zatzit> (raw)
In-Reply-To: <20240531142344.1420034-11-lvivier@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2206 bytes --]
On Fri, May 31, 2024 at 04:23:44PM +0200, Laurent Vivier wrote:
> buf_size is set to sizeof(pkt_buf) by default. And it seems more correct
> to provide the actual size of the buffer.
>
> Later a buf_size of 0 will allow vhost-user mode to detect
> guest memory buffers.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Stefano, I think this one would also make sense to apply immediately,
independently of the rest of the series.
> ---
> tap.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tap.c b/tap.c
> index c436d2d7b72b..28b515906f3b 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -602,7 +602,7 @@ resume:
> if (!eh)
> continue;
> if (ntohs(eh->h_proto) == ETH_P_ARP) {
> - PACKET_POOL_P(pkt, 1, in->buf, sizeof(pkt_buf));
> + PACKET_POOL_P(pkt, 1, in->buf, in->buf_size);
>
> packet_add(pkt, l2len, (char *)eh);
> arp(c, pkt);
> @@ -642,7 +642,7 @@ resume:
> continue;
>
> if (iph->protocol == IPPROTO_ICMP) {
> - PACKET_POOL_P(pkt, 1, in->buf, sizeof(pkt_buf));
> + PACKET_POOL_P(pkt, 1, in->buf, in->buf_size);
>
> if (c->no_icmp)
> continue;
> @@ -661,7 +661,7 @@ resume:
> continue;
>
> if (iph->protocol == IPPROTO_UDP) {
> - PACKET_POOL_P(pkt, 1, in->buf, sizeof(pkt_buf));
> + PACKET_POOL_P(pkt, 1, in->buf, in->buf_size);
>
> packet_add(pkt, l2len, (char *)eh);
> if (dhcp(c, pkt))
> @@ -810,7 +810,7 @@ resume:
> }
>
> if (proto == IPPROTO_ICMPV6) {
> - PACKET_POOL_P(pkt, 1, in->buf, sizeof(pkt_buf));
> + PACKET_POOL_P(pkt, 1, in->buf, in->buf_size);
>
> if (c->no_icmp)
> continue;
> @@ -834,7 +834,7 @@ resume:
> uh = (struct udphdr *)l4h;
>
> if (proto == IPPROTO_UDP) {
> - PACKET_POOL_P(pkt, 1, in->buf, sizeof(pkt_buf));
> + PACKET_POOL_P(pkt, 1, in->buf, in->buf_size);
>
> packet_add(pkt, l4len, l4h);
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-06-03 4:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 14:23 [PATCH v4 00/10] Add vhost-user support to passt (part 2) Laurent Vivier
2024-05-31 14:23 ` [PATCH v4 01/10] tcp: inline tcp_l2_buf_fill_headers() Laurent Vivier
2024-05-31 14:23 ` [PATCH v4 02/10] tcp: extract buffer management from tcp_send_flag() Laurent Vivier
2024-06-01 5:43 ` David Gibson
2024-05-31 14:23 ` [PATCH v4 03/10] tcp: move buffers management functions to their own file Laurent Vivier
2024-06-03 1:27 ` David Gibson
2024-05-31 14:23 ` [PATCH v4 04/10] tap: export pool_flush()/tapX_handler()/packet_add() Laurent Vivier
2024-06-03 1:32 ` David Gibson
2024-05-31 14:23 ` [PATCH v4 05/10] udp: move udpX_l2_buf_t and udpX_l2_mh_sock out of udp_update_hdrX() Laurent Vivier
2024-06-03 2:54 ` David Gibson
2024-05-31 14:23 ` [PATCH v4 06/10] udp: rename udp_sock_handler() to udp_buf_sock_handler() Laurent Vivier
2024-06-03 4:02 ` David Gibson
2024-05-31 14:23 ` [PATCH v4 07/10] vhost-user: compare mode MODE_PASTA and not MODE_PASST Laurent Vivier
2024-06-03 4:04 ` David Gibson
2024-05-31 14:23 ` [PATCH v4 08/10] iov: remove iov_copy() Laurent Vivier
2024-06-03 4:05 ` David Gibson
2024-05-31 14:23 ` [PATCH v4 09/10] tcp: remove tap_hdr parameter Laurent Vivier
2024-06-03 4:12 ` David Gibson
2024-05-31 14:23 ` [PATCH v4 10/10] tap: use in->buf_size rather than sizeof(pkt_buf) Laurent Vivier
2024-06-03 4:20 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl1Ekzttdq33hYtw@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).