Re: [PATCH v6 1/8] tcp: extract buffer management from tcp_send_flag()

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 3005 bytes --]

On Thu, Jun 13, 2024 at 11:35:53AM +0200, Stefano Brivio wrote:
> On Thu, 13 Jun 2024 09:31:44 +0200
> Laurent Vivier <lvivier@redhat.com> wrote:
> 
> > On 12/06/2024 23:22, Stefano Brivio wrote:
> > > I couldn't find out why this patch breaks the the pasta_podman/bats
> > > test, yet, that is:
> > > 
> > > not ok 19 [505] Single TCP port forwarding, IPv4, tap
> > > # (from function `bail-now' in file test/podman/test/system/helpers.bash, line 235,
> > > #  from function `assert' in file test/podman/test/system/helpers.bash, line 929,
> > > #  from function `pasta_test_do' in file test/podman/test/system/505-networking-pasta.bats, line 239,
> > > #  in test file test/podman/test/system/505-networking-pasta.bats, line 472)
> > > #   `pasta_test_do' failed
> > > #
> > > # [22:54:18.306131353] $ test/podman/bin/podman rm -t 0 --all --force --ignore
> > > #
> > > # [22:54:18.367462243] $ test/podman/bin/podman ps --all --external --format {{.ID}} {{.Names}}
> > > #
> > > # [22:54:18.394935392] $ test/podman/bin/podman images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
> > > # [22:54:18.419773379] quay.io/libpod/testimage:20240123 1f6acd4c4a1d
> > > #
> > > # [22:54:19.246631856] $ test/podman/bin/podman info --format {{.Host.Pasta.Executable}}
> > > # [22:54:20.084392405] /home/sbrivio/passt/pasta
> > > #
> > > # [22:54:20.167980222] $ test/podman/bin/podman run --net=pasta -p [88.198.0.164]:5727:5727/tcp quay.io/libpod/testimage:20240123 sh -c for port in $(seq 5727 5727); do                              socat -u TCP4-LISTEN:${port},bind=[88.198.0.164] STDOUT &                          done; wait
> > > # [22:54:37.256040883] x2024/06/12 20:54:37 socat[3] E read(6, 0x7fe675cd6000, 8192): Connection reset by peer
> > > # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
> > > # #|     FAIL: Mismatch between data sent and received
> > > # #| expected: = x
> > > # #|   actual:   x2024/06/12 20:54:37 socat\[3\] E read\(6\, 0x7fe675cd6000\, 8192\): Connection reset by peer
> > > # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > > 
> > > meaning that the data transfer is actually fine, but we reset the
> > > connection instead of an orderly shutdown.
> > 
> > How do you run this test?
> 
> It's in the test suite, see test/README.md. Make sure you have a local
> build of Podman with 'make podman' under test/.

Running 'make' in test/ will clone/update and build podman/

> You can also skip other
> tests by commenting the rest out in test/run, then do ./run from test/.

You can also run them manually by going into test/system in the podman
tree, and running
	CONTAINERS_HELPER_BINARY_DIR=/path/to/passt bats 505-networking-pasta.bats

With either option you'll need bats installed (the Fedora package is
just 'bats')

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]