From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 574E75A004E for ; Thu, 13 Jun 2024 16:36:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1718289414; bh=GMIkSywB69BGt0KNSullo2kKRbSwpzGsyetUEB5G9UU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iCzYIGnlkPPU6+ELUo5uznAi/clY24VDJrlGK2JnKur31Bt9C35n3cwEeeHDeroFc CN9FCGqp49ZzIQg2mcZuqWLRadnSf4JRQYR3/9z5eTyXGN31E45Lbl/efcLnV2yWU9 s11kt2CIX+WAoCtiN00PO2I7/4ze0HkJ4Cm6Fst4atWux1ptf9j2K68TbA2kq1hKPX FlOM6nhYpt46pXPMIMJ47CpY+r6mVjevf/pFW2SK5L5Tj8VQkbhV78u2DpbeQ01tVN AD9O75V1XeIcBZ+ML1NkLcOUj3ZoPsiK370N2ctDaAE/Hyv08PPe0UcIkvTO8qnrAJ it6GWPRPOMLEg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4W0Q3B238cz4wcJ; Fri, 14 Jun 2024 00:36:54 +1000 (AEST) Date: Fri, 14 Jun 2024 00:36:12 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v6 1/8] tcp: extract buffer management from tcp_send_flag() Message-ID: References: <20240612154734.1044883-1-lvivier@redhat.com> <20240612154734.1044883-2-lvivier@redhat.com> <20240612232210.3b1f975f@elisabeth> <20240613113553.1686f99b@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s4ltsLxahlg4PVYt" Content-Disposition: inline In-Reply-To: <20240613113553.1686f99b@elisabeth> Message-ID-Hash: GCXNHFR2WPWGJO23TX6NYDIS7LOJLZHE X-Message-ID-Hash: GCXNHFR2WPWGJO23TX6NYDIS7LOJLZHE X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --s4ltsLxahlg4PVYt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 13, 2024 at 11:35:53AM +0200, Stefano Brivio wrote: > On Thu, 13 Jun 2024 09:31:44 +0200 > Laurent Vivier wrote: >=20 > > On 12/06/2024 23:22, Stefano Brivio wrote: > > > I couldn't find out why this patch breaks the the pasta_podman/bats > > > test, yet, that is: > > >=20 > > > not ok 19 [505] Single TCP port forwarding, IPv4, tap > > > # (from function `bail-now' in file test/podman/test/system/helpers.b= ash, line 235, > > > # from function `assert' in file test/podman/test/system/helpers.bas= h, line 929, > > > # from function `pasta_test_do' in file test/podman/test/system/505-= networking-pasta.bats, line 239, > > > # in test file test/podman/test/system/505-networking-pasta.bats, li= ne 472) > > > # `pasta_test_do' failed > > > # > > > # [22:54:18.306131353] $ test/podman/bin/podman rm -t 0 --all --force= --ignore > > > # > > > # [22:54:18.367462243] $ test/podman/bin/podman ps --all --external -= -format {{.ID}} {{.Names}} > > > # > > > # [22:54:18.394935392] $ test/podman/bin/podman images --all --format= {{.Repository}}:{{.Tag}} {{.ID}} > > > # [22:54:18.419773379] quay.io/libpod/testimage:20240123 1f6acd4c4a1d > > > # > > > # [22:54:19.246631856] $ test/podman/bin/podman info --format {{.Host= =2EPasta.Executable}} > > > # [22:54:20.084392405] /home/sbrivio/passt/pasta > > > # > > > # [22:54:20.167980222] $ test/podman/bin/podman run --net=3Dpasta -p = [88.198.0.164]:5727:5727/tcp quay.io/libpod/testimage:20240123 sh -c for po= rt in $(seq 5727 5727); do socat -u TCP4-LISTE= N:${port},bind=3D[88.198.0.164] STDOUT & done; wait > > > # [22:54:37.256040883] x2024/06/12 20:54:37 socat[3] E read(6, 0x7fe6= 75cd6000, 8192): Connection reset by peer > > > # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv > > > # #| FAIL: Mismatch between data sent and received > > > # #| expected: =3D x > > > # #| actual: x2024/06/12 20:54:37 socat\[3\] E read\(6\, 0x7fe675= cd6000\, 8192\): Connection reset by peer > > > # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > >=20 > > > meaning that the data transfer is actually fine, but we reset the > > > connection instead of an orderly shutdown. > >=20 > > How do you run this test? >=20 > It's in the test suite, see test/README.md. Make sure you have a local > build of Podman with 'make podman' under test/. Running 'make' in test/ will clone/update and build podman/ > You can also skip other > tests by commenting the rest out in test/run, then do ./run from test/. You can also run them manually by going into test/system in the podman tree, and running CONTAINERS_HELPER_BINARY_DIR=3D/path/to/passt bats 505-networking-pasta.ba= ts With either option you'll need bats installed (the Fedora package is just 'bats') --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --s4ltsLxahlg4PVYt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmZrA9EACgkQzQJF27ox 2Gd75A/+LfYl1IDoKpVWmXm0XcThHhzGkEEdqP9smi+30zh/RezQYanrd5YE5wb9 7kU6uqLcSb5Eveq4IrajjZ6YcM5fgRcuy/clIQ2WJ0f2lQ9D6u6i5r0xypoxDyAn D818z1QuOgyn/jMS4soJj+iQYHJEqG3btGf1zJZd95iecu1clU9+tVcMk7aASZ0c 6ZQdsf0gcDLhiyQ2iG6dYvYJluo8vnZ2Wm0nVacKpksliH94gReob0ciGO6O0xw2 MRU+ga+VjHFBDSJdEdTzlMUX9w2ghlXQq1Ku1fJZe+BjxokxnHe0lpBQeoeb91Oe fklwsasYq5bc/Td8Z3FEOFFfpVzB7DrEYzzpFtQoOC0txR9jQ5nxe6jxLeUgryQq mVJ0vKfZAgRSVmOB2ZYrDfsCFaYX8RnSvEExrRrfWnPlpAI7WYPNqtrhKLFBoLAf 5c50BS6iB0ZVzua7mnj8l7fBhJONBPAncHk0FZllfE20vbZ0FukSGXaRixba8DDP tMwYFrdFW3Ao3GGMIV5x5UCuj4kvnzWJ1PjWnrbQOTnx4wPMmwQNlREIJ20xqxko LCbl5XYA2z7b3lzl4WgVcsCP1pnEkdct+c+0IyhwS4OlFOdhbWDVVeCl5YcQHZZ3 6L0JBNCVjtcIEcAVeFJC0qYx39qlnEc6Q3zwxLt3uJxn4/3+28A= =Gfzd -----END PGP SIGNATURE----- --s4ltsLxahlg4PVYt--