From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, Yalan Zhang <yalzhang@redhat.com>
Subject: Re: [PATCH 4/6] log: Add _perror() logging function variants
Date: Tue, 18 Jun 2024 10:46:36 +1000 [thread overview]
Message-ID: <ZnDY7JPp0kaZsFXS@zatzit> (raw)
In-Reply-To: <20240617120319.1206857-5-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3522 bytes --]
On Mon, Jun 17, 2024 at 02:03:17PM +0200, Stefano Brivio wrote:
> In many places, we have direct perror() calls, which completely bypass
> logging functions and log files.
>
> They are definitely convenient: offer similar convenience with
> _perror() logging variants, so that we can drop those direct perror()
> calls.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Hm, for anything bigger than like a screenful of code, I generally
find an explicit message with strerror(errno) more useful than
perror() or equivalents, but I guess if you think these are useful.
> ---
> log.c | 21 +++++++++++++++++++++
> log.h | 21 +++++++++++++++++----
> 2 files changed, 38 insertions(+), 4 deletions(-)
>
> diff --git a/log.c b/log.c
> index 939bb93..6764b2b 100644
> --- a/log.c
> +++ b/log.c
> @@ -80,6 +80,11 @@ void vlogmsg(int pri, const char *format, va_list ap)
> }
> }
>
> +/**
> + * logmsg() - vlogmsg() wrapper for variable argument lists
> + * @pri: Facility and level map, same as priority for vsyslog()
> + * @format: Message
> + */
> void logmsg(int pri, const char *format, ...)
> {
> va_list ap;
> @@ -89,6 +94,22 @@ void logmsg(int pri, const char *format, ...)
> va_end(ap);
> }
>
> +/**
> + * logmsg_perror() - vlogmsg() wrapper with perror()-like functionality
> + * @pri: Facility and level map, same as priority for vsyslog()
> + * @format: Message
> + */
> +void logmsg_perror(int pri, const char *format, ...)
> +{
> + va_list ap;
> +
> + logmsg(pri, "%s: ", strerror(errno));
> +
> + va_start(ap, format);
> + vlogmsg(pri, format, ap);
> + va_end(ap);
> +}
> +
> /* Prefixes for log file messages, indexed by priority */
> const char *logfile_prefix[] = {
> NULL, NULL, NULL, /* Unused: LOG_EMERG, LOG_ALERT, LOG_CRIT */
> diff --git a/log.h b/log.h
> index 680baab..5be0be9 100644
> --- a/log.h
> +++ b/log.h
> @@ -19,11 +19,18 @@
> void vlogmsg(int pri, const char *format, va_list ap);
> void logmsg(int pri, const char *format, ...)
> __attribute__((format(printf, 2, 3)));
> +void logmsg_perror(int pri, const char *format, ...)
> + __attribute__((format(printf, 2, 3)));
> +
> +#define err(...) logmsg( LOG_ERR, __VA_ARGS__)
> +#define warn(...) logmsg( LOG_WARNING, __VA_ARGS__)
> +#define info(...) logmsg( LOG_INFO, __VA_ARGS__)
> +#define debug(...) logmsg( LOG_DEBUG, __VA_ARGS__)
>
> -#define err(...) logmsg(LOG_ERR, __VA_ARGS__)
> -#define warn(...) logmsg(LOG_WARNING, __VA_ARGS__)
> -#define info(...) logmsg(LOG_INFO, __VA_ARGS__)
> -#define debug(...) logmsg(LOG_DEBUG, __VA_ARGS__)
> +#define err_perror(...) logmsg_perror( LOG_ERR, __VA_ARGS__)
> +#define warn_perror(...) logmsg_perror( LOG_WARNING, __VA_ARGS__)
> +#define info_perror(...) logmsg_perror( LOG_INFO, __VA_ARGS__)
> +#define debug_perror(...) logmsg_perror( LOG_DEBUG, __VA_ARGS__)
>
> #define die(...) \
> do { \
> @@ -31,6 +38,12 @@ void logmsg(int pri, const char *format, ...)
> exit(EXIT_FAILURE); \
> } while (0)
>
> +#define die_perror(...) \
> + do { \
> + err_perror(__VA_ARGS__); \
> + exit(EXIT_FAILURE); \
> + } while (0)
> +
> extern int log_trace;
> void trace_init(int enable);
> #define trace(...) \
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-06-18 0:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 12:03 [PATCH 0/6] Fixes for early logging/prints and related cleanups Stefano Brivio
2024-06-17 12:03 ` [PATCH 1/6] conf, passt: Don't try to log to stderr after we close it Stefano Brivio
2024-06-18 0:36 ` David Gibson
2024-06-18 6:00 ` Stefano Brivio
2024-06-19 2:06 ` David Gibson
2024-06-19 8:13 ` Stefano Brivio
2024-06-20 0:12 ` David Gibson
2024-06-17 12:03 ` [PATCH 2/6] conf, log: Introduce internal log flags, instead of abusing log levels Stefano Brivio
2024-06-18 0:39 ` David Gibson
2024-06-18 6:01 ` Stefano Brivio
2024-06-17 12:03 ` [PATCH 3/6] log, passt: Always print to stderr before initialisation is complete Stefano Brivio
2024-06-18 0:44 ` David Gibson
2024-06-18 6:01 ` Stefano Brivio
2024-06-19 2:10 ` David Gibson
2024-06-19 8:17 ` Stefano Brivio
2024-06-20 0:12 ` David Gibson
2024-06-17 12:03 ` [PATCH 4/6] log: Add _perror() logging function variants Stefano Brivio
2024-06-18 0:46 ` David Gibson [this message]
2024-06-18 6:02 ` Stefano Brivio
2024-06-19 2:11 ` David Gibson
2024-06-19 8:25 ` Stefano Brivio
2024-06-20 0:13 ` David Gibson
2024-06-17 12:03 ` [PATCH 5/6] treewide: Replace perror() calls with calls to logging functions Stefano Brivio
2024-06-18 0:50 ` David Gibson
2024-06-17 12:03 ` [PATCH 6/6] treewide: Replace strerror() calls Stefano Brivio
2024-06-18 0:51 ` David Gibson
2024-06-18 6:02 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnDY7JPp0kaZsFXS@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
--cc=yalzhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).