From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 829D45A004F for ; Thu, 11 Jul 2024 03:54:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1720662836; bh=pM4HroI55KIpAhJwwNb3CsWyGS1rUquSz/Mo7q6g3Wo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ll0S6lmtcEqTuippFgNQgDvUJqhOuSuA0BwimKcQAkgg4mQcr3kfOJ/bSAKhIdwv5 SuEXZhRWlZybNT9bOBaO6QIbgNISWtQ+4Ebx/ETNwa1bhea5XJMkvHmUEOCLXr4i3V sv/2uALpNmaHN0Yk+YBZnuByT0hQvimxsKbHGDflVgGMODQCj95DC349yNFU2gtsPf ziSQelToJ96zFvE+6XecpDVrZnd09mpLLWsVZUeiSSR6R548IR0JlvN3x0NjAyq5cx R3qDp44ApVLwm06hlWoCZ+di9CH49TdyHEnRZ2kFsMR6zX7xlaO5ZpilC+zG5R28pe S7R6F+3Yvt8Gg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WKHnw48Pzz4wx5; Thu, 11 Jul 2024 11:53:56 +1000 (AEST) Date: Thu, 11 Jul 2024 10:27:40 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v7 15/27] flow: Helper to create sockets based on flowside Message-ID: References: <20240705020724.3447719-1-david@gibson.dropbear.id.au> <20240705020724.3447719-16-david@gibson.dropbear.id.au> <20240710233201.3a05342b@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RPCjX/WphzTvvwA4" Content-Disposition: inline In-Reply-To: <20240710233201.3a05342b@elisabeth> Message-ID-Hash: L7V7ZAT2CM4UGMK6KELHU6LJJCPTXFCW X-Message-ID-Hash: L7V7ZAT2CM4UGMK6KELHU6LJJCPTXFCW X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jmaloy@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --RPCjX/WphzTvvwA4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 10, 2024 at 11:32:01PM +0200, Stefano Brivio wrote: > On Fri, 5 Jul 2024 12:07:12 +1000 > David Gibson wrote: >=20 > > We have upcoming use cases where it's useful to create new bound socket > > based on information from the flow table. Add flowside_sock_l4() to do > > this for either PIF_HOST or PIF_SPLICE sockets. > >=20 > > Signed-off-by: David Gibson [snip] > > + default: > > + /* If we add new socket pifs, they'll need to be implemented > > + * here */ >=20 > For consistency: >=20 > /* If we add new socket pifs, they'll need to be implemented > * here > */ >=20 > there are a few occurrences in the next patches, not so important I > guess, I can also do a pass later at some point. I did some grepping, and I think I squashed the ones added by this series. There are also some instances that are already merged. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --RPCjX/WphzTvvwA4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaPJvsACgkQzQJF27ox 2Gflfg/8CkGVg9MNlpJPtOkW5OIhu5k3v3B2B/LxWEkPryFgkyJ6rhM9fqcdkpCj pAR1bYt6zRdxkygtxN0lgl2EVvSrVTybyJlLBtFreiprsn9xcAfzDw0h0qGnlAVM QReceLPedva8qOhUnW54YGwUH8KV6CapREY4ddTdPuaHbQ0LKA21iQnL6oQKZFQR MbccvCY17esu37/gecyMVXRTZx3yJlEjESAkC4y8Je6sxYUiF/W5Ooq3IoJOKNED 7Z9mNDBb0gl+L01RWLxPxXMxQa3WZJkaJeMBZUGatSqijMhrmzkivE9IOdumWo90 sk/j2VFnBy9yRMz7HgXV/eKlD7azCNcpHk27nQuyFLNEG11100yCdSU+HgL8aw8S U7F9HQtAFuBtIjGnkYZMDRGRGdH/VT/EntTmI4mR0Wc7MlJP/GctHyg9ilAS6oYb S0BStIXNGg5BjAucjvHR7Ej91IwSgqYCXDKxWdqUIcTFBhyGEiD4ZxAwcA3ySkhp iSJ+yCiPfnducmqwQTI6nzyV6Zzvx9TZMbb7w0eZRaMX5vcfWxbOq1J9XpGUFjf8 +ggHaGI2TJunjyAFBGj9UqZkPunX7/p8iyObNr+eSebzLIYUark7dKy0RpHvP33F m9fUw6ewR66Yr9W7ee8v4HT12rCKai/L9xc0pvTmAdbjmxE3WSs= =5XsD -----END PGP SIGNATURE----- --RPCjX/WphzTvvwA4--