From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 4A8065A004F for ; Thu, 11 Jul 2024 03:54:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1720662836; bh=3iDcK1hnLIy1kDi98dzGButbmc7AGDKLN36DIQaFx+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rU7EU7dLoqQGlnyAqVHNNq7mDG9YSmFnMgOey3eukA2EjCeCOeeDcV6SWhk0Ogp9A R/hqQ7xOiZhuWjxPB69q9temZ1qkCzCjxtLnyKneiUeGlZXUKb9ADTH2ih8nnNMaGK RRoGuRZYl2gwawWOgwFp/cf5GJaC+LXXN6KDkecbqoYLfPcjK6ONUdBgEOsBBf+T2C mMzQ8kyAQKDSc53sAVN9tfzr5LInMw1UXwuHjOdR2Afks87NSOs8Mw/UAWBpU//T8p YF8cs0czuc8ZRmRaiPv3Uj5L2a/vhyXMK1XVbK3LwzbVrVsZYJKrWipY6JcgnFArS4 3Lmas6jXbeQeg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WKHnw4Pzfz4wym; Thu, 11 Jul 2024 11:53:56 +1000 (AEST) Date: Thu, 11 Jul 2024 10:45:35 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v7 23/27] udp: Find or create flows for datagrams from tap interface Message-ID: References: <20240705020724.3447719-1-david@gibson.dropbear.id.au> <20240705020724.3447719-24-david@gibson.dropbear.id.au> <20240710233656.303b399d@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GMLdx4SevzGmW+TA" Content-Disposition: inline In-Reply-To: <20240710233656.303b399d@elisabeth> Message-ID-Hash: 7IPVE3CVB4O7H3QNODQZHIH2DZN4BWDD X-Message-ID-Hash: 7IPVE3CVB4O7H3QNODQZHIH2DZN4BWDD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jmaloy@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --GMLdx4SevzGmW+TA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 10, 2024 at 11:36:56PM +0200, Stefano Brivio wrote: > Some nits in the commit message only: >=20 > On Fri, 5 Jul 2024 12:07:20 +1000 > David Gibson wrote: >=20 > > Currently we create flows for datagrams from socket interfaces, and use > > them to direct "spliced" (socket to socket) datagrams. We don't yet > > match datagrams from the tap interface to existing flows, nor create new > > flows for them. Add that functionality, matching datagrams from tap to > > existing flows when they exist, or creating new ones. > >=20 > > As with spliced flows, when creating a new flow from tap to socket, we > > create a new connected socket to receive reply datagrams attached to th= at > > flow specifically. We extend udp_flow_sock_handler() to handle reply > > packets bound for tap rather than another socket. > >=20 > > For non-obvious reasons, this caused a failure for me when running under > > valgrind, because valgrind invoked rt_sigreturn which is not in our > > seccomp filter. >=20 > That might be because the stack area needed by udp_reply_sock_handler() > is now a bit bigger... or something like that, I suppose. >=20 > > Since we already allow rt_signaction and others in the >=20 > rt_sigaction >=20 > > valgrind, it seems reasonable to add rt_sigreturn as well. >=20 > valgrind target Revised accordingly. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --GMLdx4SevzGmW+TA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaPKy4ACgkQzQJF27ox 2GeceRAAg/8O3OFiQSVGZ9JAAKJ9e+d07xqdhj69QVUVZx8laOXCuteAKEmnH9Cr jkkHDSEFlxbSzppivf69Ux5sEe82nDV0WjGelp5AFpA+zUT/i6HZ4qsaUg1wumy8 K+v/lD1Rq4VzbdkTAR+DoxhVtbMzFro2DAXiwChhQrbeUoYW/sDZB+EhEpb2OxF8 uapcDViUfRA2ex3pXYIxp5Je6uefSmX2naPnjnmHQBKHtgNqOtKBv3yDRfIMoWbx 5v74nATqFbfW6wFyoZVxn0QeTXlCgei/GCnV780TPU9Qj4zqxBNAdCH7uq/dVYab wCyHj9QiAvyU6dy/jyVM606BocOjc75HMbycPr9/8KcdIzgVbaDYUAi4YduFqKdq wDxyFFbTeIT2PGUz2G0rdljzDWCxzY4pcvi6eydv66a6TvWDcFOkKanAKfvsYeWe /Bskk67x9na8cXCrvRLVvIcs8onYFXhmWFFYQ/l6/meII6xwp/E9SKJGsCZsN0q1 kDAo09RZrVheJF5q6zznW6eCam3rUtxYHbpNq1+m5MEKXumxQRBVtY7gBobYvdfW yXlf+kWX+jxyAhtaH6fvb9ydOHQtAajkiL1qkGhQMU6lIRPNrhdIBNtgW9ZssxC8 WvKkmrc5NG5eb2Kv4wNp5OWyZ+kHOpRpOEL9WpeNtWVi9vDcKWE= =42RH -----END PGP SIGNATURE----- --GMLdx4SevzGmW+TA--