Re: [PATCH v7 24/27] udp: Direct datagrams from host to guest via flow table

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]

On Wed, Jul 10, 2024 at 11:37:36PM +0200, Stefano Brivio wrote:
> Two nits only:
> 
> On Fri,  5 Jul 2024 12:07:21 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > This replaces the last piece of existing UDP port tracking with the
> > common flow table.  Specifically use the flow table to direct datagrams
> > from host sockets to the guest tap interface.  Since this now requires
> > a flow for every datagram, we add some logging if we encounter any
> > datagrams for which we can't find or create a flow.
> > 
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> >  flow_table.h |  14 ++++
> >  udp.c        | 188 +++++++++++++++------------------------------------
> >  2 files changed, 67 insertions(+), 135 deletions(-)
> > 
> > diff --git a/flow_table.h b/flow_table.h
> > index 1faac4a7..da9483b3 100644
> > --- a/flow_table.h
> > +++ b/flow_table.h
> > @@ -106,6 +106,20 @@ static inline uint8_t pif_at_sidx(flow_sidx_t sidx)
> >  	return flow->f.pif[sidx.side];
> >  }
> >  
> > +/** flowside_at_sidx - Retrieve a specific flowside
> 
> flowside_at_sidx()

Done.

> > + * @sidx:    Flow & side index
> > + *
> > + * Return: Flowside for the flow & side given by @sidx
> > + */
> > +static inline const struct flowside *flowside_at_sidx(flow_sidx_t sidx)
> > +{
> > +	const union flow *flow = flow_at_sidx(sidx);
> > +
> > +	if (!flow)
> > +		return PIF_NONE;
> 
> Usual extra newline.

Done.

> > +	return &flow->f.side[sidx.side];
> > +}
> 
> I finished reviewing all the other patches, no further comments,
> everything else looks good to me.
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]