From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id C9F915A031B for ; Thu, 11 Jul 2024 03:54:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1720662836; bh=1xuu0tdTG82tc0zd2aaB8SA6EGDqV9TpykjZGx+Zqg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eezuyRlFM4/TBWVJt855nFAeLZzxtdHUMHJ4j+oFSpsBlSRAVuT33pDUoqwPStrGU T6PtS0EY2Qq4XcMEQSimBPQNBmgBs6liKOol+HVnqqGmbuZedP819DHFmBGY9Xfrb8 Anma9iBbGP1WGD4g7hNXH3fBnFfQNEgzNrsizRoywR8Z5OuOtnL5OTuwqV2FTmcRPE RW8ZOiSmyzAXZWVfDrca6uco7SHW88b/QwdBJWalk0WE8vZPqiZrZa+phk0Pn7Jndn AZ0vnH7PxvzqyuPVvU+sfe10yvv3uCiHrIjMIPeifixIvt6/PWSuSgLU5pLvQi1RRt FxaChJuEBf38A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WKHnw4Whnz4x04; Thu, 11 Jul 2024 11:53:56 +1000 (AEST) Date: Thu, 11 Jul 2024 10:46:37 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v7 24/27] udp: Direct datagrams from host to guest via flow table Message-ID: References: <20240705020724.3447719-1-david@gibson.dropbear.id.au> <20240705020724.3447719-25-david@gibson.dropbear.id.au> <20240710233736.15a34a26@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="peM4oassmWIeh87d" Content-Disposition: inline In-Reply-To: <20240710233736.15a34a26@elisabeth> Message-ID-Hash: MYKVFDIB3PIDBDFRBPM3W4C3ZBE2OZYS X-Message-ID-Hash: MYKVFDIB3PIDBDFRBPM3W4C3ZBE2OZYS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jmaloy@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --peM4oassmWIeh87d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 10, 2024 at 11:37:36PM +0200, Stefano Brivio wrote: > Two nits only: >=20 > On Fri, 5 Jul 2024 12:07:21 +1000 > David Gibson wrote: >=20 > > This replaces the last piece of existing UDP port tracking with the > > common flow table. Specifically use the flow table to direct datagrams > > from host sockets to the guest tap interface. Since this now requires > > a flow for every datagram, we add some logging if we encounter any > > datagrams for which we can't find or create a flow. > >=20 > > Signed-off-by: David Gibson > > --- > > flow_table.h | 14 ++++ > > udp.c | 188 +++++++++++++++------------------------------------ > > 2 files changed, 67 insertions(+), 135 deletions(-) > >=20 > > diff --git a/flow_table.h b/flow_table.h > > index 1faac4a7..da9483b3 100644 > > --- a/flow_table.h > > +++ b/flow_table.h > > @@ -106,6 +106,20 @@ static inline uint8_t pif_at_sidx(flow_sidx_t sidx) > > return flow->f.pif[sidx.side]; > > } > > =20 > > +/** flowside_at_sidx - Retrieve a specific flowside >=20 > flowside_at_sidx() Done. > > + * @sidx: Flow & side index > > + * > > + * Return: Flowside for the flow & side given by @sidx > > + */ > > +static inline const struct flowside *flowside_at_sidx(flow_sidx_t sidx) > > +{ > > + const union flow *flow =3D flow_at_sidx(sidx); > > + > > + if (!flow) > > + return PIF_NONE; >=20 > Usual extra newline. Done. > > + return &flow->f.side[sidx.side]; > > +} >=20 > I finished reviewing all the other patches, no further comments, > everything else looks good to me. >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --peM4oassmWIeh87d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaPK2wACgkQzQJF27ox 2GdQ1g//exLW9cLmyKRmulicb0bpIXODfcBdXPkNqzGoQPoYlfZr+NvmHf2c4yMQ YUmHBZi6ExeNPy2RubkcqHC63dkr/at2LgPOJ3Mrq1INwF5R5SrytEMVJ8/wwSTQ QnFWB6QWX2fcnSKq7KY6sZ5jvZiPPpMoi2SOAgPjjyS4DbQljjwpuhfmHEbobUPS JOtO44/PILSRRicgx6lbyRM29QzUl7FxMwopgRfMqsjTXUENOiab+CJFzBZBVhYD loVhOO0TZaB3pL4ZzqC5aesNoqLRot9dwhAZBsAh1GM6XWnPPQKeVwxc5ae7VY/+ gbb++KSLga3ItGPDL5YQ3VRhsj5kSJYtbNrwTSb5bTsqiw5gbQiWjfsTbqymedcr 2TUHFh5CvPTJrK12Wr5YqjHDOA64ULB67vTW0la17wGNCpGIBA9X8LHMdlOl1St+ oajBzDqjiojb6JzFJfcy187sqsLRqEZVsIic8h6q7ecwDAV5dVBTv6WCuaWU0JJH cbV8jwov1ItFV9k2TICEB+mdkEI9WlS8rRCqdT17ZTXVjhBsXKbdfrnke0AD6tpE NgtfdZj6M4/7CEy6U+F/KKQ4ofKBZxogv3Watr/RQQ0RBHQ2zRkwhspHkDfnIh67 oNvEUl5VrESUx8YwvU6OpuhbvwhxwThAmV/l5jd5lMx3VPwqp/w= =RThw -----END PGP SIGNATURE----- --peM4oassmWIeh87d--