On Thu, Jul 04, 2024 at 11:20:07PM +0200, Stefano Brivio wrote: > On Thu, 4 Jul 2024 14:58:27 +1000 > David Gibson wrote: > > > udp_buf_sock_handler() takes the epoll reference from the receiving socket, > > and passes the UDP relevant part on to several other functions. Future > > changes are going to need several different epoll types for UDP, and to > > pass that information through to some of those functions. To avoid extra > > noise in the patches making the real changes, change those functions now > > to take the full epoll reference, rather than just the UDP part. > > > > Signed-off-by: David Gibson > > --- > > udp.c | 63 +++++++++++++++++++++++++++++++---------------------------- > > 1 file changed, 33 insertions(+), 30 deletions(-) > > > > diff --git a/udp.c b/udp.c > > index eadf4872..6301bda2 100644 > > --- a/udp.c > > +++ b/udp.c > > @@ -477,25 +477,26 @@ static int udp_splice_new_ns(void *arg) > > > > /** > > * udp_mmh_splice_port() - Is source address of message suitable for splicing? > > - * @uref: UDP epoll reference for incoming message's origin socket > > + * @ref: Epoll reference for incoming message's origin socket > > Nit: in 1/11 (and later in this patch), this is "epoll" instead, which > looks more correct to me as it's a proper noun, but not capitalised. > Same for udp_update_hdr6(). Good point, fixed. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson