From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 4AA755A004F for ; Fri, 05 Jul 2024 02:01:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1720137649; bh=FORVAP0+RPSQ+mS/Mn1MLyXee48sMYTJVRVLcxZehsM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NIq/ZEcWhNVMIzHiu0gfmO0fvVUm0/ykUm5SgkINldA7+pLNf9ygPccEgcYIepWer hIBb61DBfuS/6/2VGrJRXnBsOAEJbzT8ok9RMTty5mZ7Rd4n6S9yfcgbU4jZLloyXi iKDTfUSLEPzPRvgWIP+KCpWbts7+FFIDiXxsQR9ypx7BCTusvoCKLTefrd7h7ow84/ 53d8Pgq+n+RuEd2EqdYvk5NeoAIzLj8ZUB1+A1FDnoK0wlwsI0HAK+zxGtxTM7QznU DEDiRfnex9o5bSEMG2P7r7vZK+usx8CN2DYkHDH8EMDPzLfW9bEBRhGjGcECh2BGGH J3LSvIB2Huknw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WFYZ93LsLz4wxs; Fri, 5 Jul 2024 10:00:49 +1000 (AEST) Date: Fri, 5 Jul 2024 09:54:22 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 03/11] udp: Pass full epoll reference through more of sock handler path Message-ID: References: <20240704045835.1149746-1-david@gibson.dropbear.id.au> <20240704045835.1149746-4-david@gibson.dropbear.id.au> <20240704232007.0aa0cbe5@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lmg/25/YO8x/u6RE" Content-Disposition: inline In-Reply-To: <20240704232007.0aa0cbe5@elisabeth> Message-ID-Hash: WOCLTHRAYDPDV4TW7K44C53WXI6LWAZZ X-Message-ID-Hash: WOCLTHRAYDPDV4TW7K44C53WXI6LWAZZ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Lmg/25/YO8x/u6RE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 04, 2024 at 11:20:07PM +0200, Stefano Brivio wrote: > On Thu, 4 Jul 2024 14:58:27 +1000 > David Gibson wrote: >=20 > > udp_buf_sock_handler() takes the epoll reference from the receiving soc= ket, > > and passes the UDP relevant part on to several other functions. Future > > changes are going to need several different epoll types for UDP, and to > > pass that information through to some of those functions. To avoid ext= ra > > noise in the patches making the real changes, change those functions now > > to take the full epoll reference, rather than just the UDP part. > >=20 > > Signed-off-by: David Gibson > > --- > > udp.c | 63 +++++++++++++++++++++++++++++++---------------------------- > > 1 file changed, 33 insertions(+), 30 deletions(-) > >=20 > > diff --git a/udp.c b/udp.c > > index eadf4872..6301bda2 100644 > > --- a/udp.c > > +++ b/udp.c > > @@ -477,25 +477,26 @@ static int udp_splice_new_ns(void *arg) > > =20 > > /** > > * udp_mmh_splice_port() - Is source address of message suitable for s= plicing? > > - * @uref: UDP epoll reference for incoming message's origin socket > > + * @ref: Epoll reference for incoming message's origin socket >=20 > Nit: in 1/11 (and later in this patch), this is "epoll" instead, which > looks more correct to me as it's a proper noun, but not capitalised. > Same for udp_update_hdr6(). Good point, fixed. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Lmg/25/YO8x/u6RE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaHNi0ACgkQzQJF27ox 2GfMMQ/+NMm2EO6U005VkGDHkruQqlgPZbuLxltnNwNteRbXkXerRHOnDLypOETP Joe8vMHm4JbpPohjqDxinWrjqkATKHvZQg+wstxzTE2DXFtTxKfBICYnjWWJomf9 KbBrliFY8Tnf64hAwi5YNRO+9MB3u44z9LK3sNK1V07FgCX5AtUd4TIRynEVA4dq bYklIP/x21b1H+vuSxGwNsQOzMeODKtI5oXHpOvqTrcd7OGOLejEYAZyCDKfZhsJ oFX2RqJyjPRb7JK7Doprr7oEYBRYvT6Wh1yzwTZLu4W2gj5t0oqUoJopprclVggr p748FU27h24MpN4+BVY6dA40cLhn59IBHLBEsR0blOqyrFyXftlXYZj7rdO4onz+ GOoXkwFozUTDfZ1RUytfXLxtC/xDPBHpV2bjZfDCMSf6oJvnSck7KQNu2Ld7h3Lb XXRAX+MhnoIrmS+M3LUywxQVsrUcTUpDQufIzm498HgiaCPxDRoaAOzflohrZDy6 pjHJ5d9KmIOsjS10UcxuGWZYh8o28OawTOd9HGc9MULoX9w+t4zZjYRB8CpJvUyJ oV7d94Vo0+15OLyT4Bj8J16ZdVugtc/+cP7yp9cMw0F8YWfMU6w2BtuaBUnj+kDg 6AFVXSCBwV3qMgt31Xsp+jMGmfA0At1/HuhY7KlXcTJkIEOREnw= =9fcM -----END PGP SIGNATURE----- --Lmg/25/YO8x/u6RE--