From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 10D5D5A031C for ; Fri, 05 Jul 2024 02:01:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1720137649; bh=EKy/Ga489AVefmZaKNWTtzXRggdGX2Oie1fq/4P+ty8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IR52sQeLyE5VPqxWeNycGPPpmpXVnN3vlcGuptP4XaKQZh+27wx1RI22aI4LweC1e HNluwhvO0aqyKBfPciszFXREVP4z8cXJKSHlA4sW5CYLOoitZDPYYlYV7yTkJZ547S CvaW+0nKLzKt2UO7j+wRBgWxhEIpQI4XlwUkicyzOdK4D5LS+QjzeZ8SNKP96v6MlN n1jWe1+Rb43PdQiS1NCCzWk8nDrolce5IuZvPOh09+yhDjZBd8GJChPGjievOBC+Xo xnRkHydaMzw7FtXt+yof4NR+GmwYMZVxi8Grhl/96wvbvBa+nxR1A5JhU1LKN48JdK tIOBrPWE1JNFw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WFYZ93TNjz4wny; Fri, 5 Jul 2024 10:00:49 +1000 (AEST) Date: Fri, 5 Jul 2024 10:00:37 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 04/11] udp: Rename IOV and mmsghdr arrays Message-ID: References: <20240704045835.1149746-1-david@gibson.dropbear.id.au> <20240704045835.1149746-5-david@gibson.dropbear.id.au> <20240704232053.2e7c735d@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6SY9lsGH4eyMC/J+" Content-Disposition: inline In-Reply-To: <20240704232053.2e7c735d@elisabeth> Message-ID-Hash: OBV3LNFYNDOVGETH3XV2NMS3ID3RVIGW X-Message-ID-Hash: OBV3LNFYNDOVGETH3XV2NMS3ID3RVIGW X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --6SY9lsGH4eyMC/J+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 04, 2024 at 11:20:53PM +0200, Stefano Brivio wrote: > On Thu, 4 Jul 2024 14:58:28 +1000 > David Gibson wrote: >=20 > > Make the salient points about these various arrays clearer with renames: > >=20 > > * udp_l2_iov_sock and udp[46]_l2_mh_sock don't really have anything to = do > > with L2. >=20 > The original idea behind that 'l2' there was to have the type of > destination in the name first, and then the source ('sock'). Ah! That makes sense once you know. > On the other hand, they're actually clearer this way. Right, I think this is more obvious out the gate. > > They are, however, specific to receiving not sending not receiving. >=20 > I failed to decrypt this one. :) Oops, corrected. > > Rename to udp_iov_recv and udp[46]_mh_recv. > >=20 > > * udp[46]_l2_iov_tap is redundant - "tap" implies L2 and vice versa. > > Rename to udp[46]_l2_iov > >=20 > > * udp[46]_localname are (for now) pre-populated with the locan address > > but the more salient point is that these are the destination address for > > the splice arrays. Rename to udp[46]_spliceto >=20 > Very slight preference (but not worth a lot of changes, in case): > udp[46]_splice_to. To me it's not immediately obvious those are two > words otherwise. Easy fix, and on consideration I prefer "splice_to" as well. Changed. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --6SY9lsGH4eyMC/J+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaHN6QACgkQzQJF27ox 2Ge27A/+MZP0BBw8M4HXTAQaYaDPW7BRdn3ZbjOiYKxslH1VxcY7weY/fnNbPDgq L4dAt6rqsFWUeHLQEgZdttY8Q/IYo9Ogj9Z8ygKHTbyZMJWwcGXIirMd5KMLXov3 1ou+Ik2l6eRX6sgE98keshnuLMRXAiwkSocWYWblde+bcO7UNA6FFYihkI0Hu52s xmkFxofiEH5Ra0fp33pmILWpLn3dth/QCf+G8CCZCDFyl/WxMr+7Ifj91uegMZOT GzRp3sVR2n4qUkoQNzy5U2d+JeNyG5nu9Erys+ooo+6RnbtstuTvkakQEdEYe+Jz 1SJQyQpo3S2COsNjNW2BwPvxgpFSsZxeVjzZXMh5e+4+tnynLUg2hnZF0+Dzqur9 lPMS9fpglvae2U/LdyvhbWTw2lsKR9CIIQfAknRq5u90eshCNHXqiTrhUrT/qPj1 WM5RAFBihCnTsubz6dotpNTvvnKppyuflLfjn4HSY3545sNvDviQdoeTEL1n6sx+ mWoeYxQy0HADdHhwSSF8ejm4S4xh/FkhP0WINm39a63kvsWVWyK/K2wgpwdECYid bMWt2wzhlLwko1963sf21ZLa4IwR5V/NNr/WxxyBSiifC2qzaPB+z4bvtSOGnzmJ ytDbs3BDsmY+0S3QnFcuIx7RgKgOHZ/7YrWlNjm/6wYcm+2NNg8= =09Ng -----END PGP SIGNATURE----- --6SY9lsGH4eyMC/J+--