From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id ED3695A004F for ; Mon, 15 Jul 2024 02:43:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1721004189; bh=8iouNPdz79aNoymIJRC+EI0aeCvSPo3uhLiB21Tr1uA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZXdMHAWgbYk7qG2xKZeML6npQBH13N9/UZE07xTWWvwqI4zrh0bvGlc9cOUHMfxMI z5OUmTjYxjP5+ALDlX9Smc5yrmT+fjH5/CTuHAmUG6O7CdVAq0KJU5ub8zTpLff86u nSuZQPYgpNHizB/uZVOLDEuifwOrTUVEhrIfNe5seThz66s3vX3BzOMpTE+bozeq5L bwt2qb2NDLS6InIa/pGuKDtA0CL5ClQqs+P2utQ6s0n4z0Fac1qp3REzTTBFwezhX3 qmFQgOgyjVBnDjwrAad9v5V2K5iJ/7XAlGp0A/yA5ZTrvMdeFxd7q5KXHAIm0HRSKd OV1AQ7ASU1XCA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WMk2P4XwQz4x1y; Mon, 15 Jul 2024 10:43:09 +1000 (AEST) Date: Mon, 15 Jul 2024 10:37:30 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH 5/5] vhost-user: add vhost-user Message-ID: References: <20240621145640.1914287-1-lvivier@redhat.com> <20240621145640.1914287-6-lvivier@redhat.com> <66f54470-cf49-4a31-bb98-fa7b684100b5@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3RHr3byTBuLfnSPP" Content-Disposition: inline In-Reply-To: <66f54470-cf49-4a31-bb98-fa7b684100b5@redhat.com> Message-ID-Hash: ZPI7S27AE6P2ZLPOKM3L6FANLOBZ5QPO X-Message-ID-Hash: ZPI7S27AE6P2ZLPOKM3L6FANLOBZ5QPO X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3RHr3byTBuLfnSPP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 12, 2024 at 04:49:07PM +0200, Laurent Vivier wrote: > On 24/06/2024 07:05, David Gibson wrote: > > On Fri, Jun 21, 2024 at 04:56:40PM +0200, Laurent Vivier wrote: [snip] > > > +/** > > > + * struct tcp_payload_t - TCP header and data to send segments with = payload > > > + * @th: TCP header > > > + * @data: TCP data > > > + */ > > > +struct tcp_payload_t { > > > + struct tcphdr th; > > > + uint8_t data[IP_MAX_MTU - sizeof(struct tcphdr)]; > > > +}; > >=20 > > This could be common with tcp_buf.c, couldn't it? >=20 > In fact, no: because we cannot have the ((aligned)) attribute as the addr= ess > is provided by the guest. Ah, right. It still concerns me a bit, having two structures with the same name in different parts of the code, when the difference between them is so subtle. Could we use a common struct for both "buf" and vu, and put the alignment constraint on the actual array in the buf code, rather than on the type? --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --3RHr3byTBuLfnSPP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaUb0kACgkQzQJF27ox 2Gc0VhAAoBatpEhnuAarkzEu0PWxWHIZ6e9mJR27yLjGZwyPPrk54OZLgWiyretF /gSWHQq5xuxAySOQn3ejC+nKSMQTq6O+MrFyGNLOQGVlh4ed6aOt3DVnAHRZlo81 3B2HNvWtbkYga8vkFQbtfaQ4ItnQIWDmtCSQWXNM5jA4u4mvctzy3f4jFV2beb2q fKzbnjN4EaUPZJwpXP8JTYNqSKo1jIHGeRcRQxawIQ/0wq+J4uW2sJuk4Pa+5hEd M0cdhIuRRz8pipUiY5wFY1Bw38tN9HqHaR8JQPXJ6mYSvlgah7Pv5kWi8H7rePYh GEgZ6tKThjjKdNgI+llgd5tW0jb8Xqc42ykOqMaREpTUhv2Ga3CWBUDeloTv9DYu +1hZXPrUnBkSSIVvP5CbaUZCae/YaTKVdBnTX1372UBfcdJpcXJ7hg8IYFgovWv+ aUlnuHxQIsWxbVPrxFUwVGJJ8utKRRJOrd66sqDlBH3/K+VEavidXuJ9k8bkRPVA NQMln8cxqqsExVETN2AP1XNg/9fntXSUHpLVez3Q2AvQvHDhItUw6iL+g6xrLQVf eflQpF1txP3se5qazjTLTXY02yKPxeEih/8+wcITipWRNb7n4koUeCxgbnbaHdPc RShUWqtvWBSVtppLWe2zme7MVNDhOlEqyzXPin1+Sgf/6jObzBA= =3mFa -----END PGP SIGNATURE----- --3RHr3byTBuLfnSPP--