From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id ED4BF5A004E for ; Wed, 17 Jul 2024 07:28:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1721194089; bh=LEiC95gSODvKURi1Hu8jbKrmnBp4hOSVtmha0UZSa7k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hAUPbXgn/GhMKfKSlC5/sy7cPvkdP3N/THioOfxpGsYqnSwjs4U1eCN6TrzNhUc4o Tu7eVkW9+3YvwgzprG3hoAjqAfHofINgja5JwhSdlji2XmLaJD8GbI+y++pQLGi6IO vkiZGXH8FXgy08rmEH3Dshu7Wo51a1FOLlgrVGkYRHuxveoNLrDZAm0S2Xlg2PdnJJ wiFrV+UOtY1aLdzhKnbLSzL0ccNlQ71O2XGu1g1squl6ZLE1XkWZEo9ondBNDKEdym O7S76GnhdJZ93CXDInhU0kqD8Z3zzMX+azkWZqq+lt0QE+8Jj3nm2ictmEPucHHaR8 9m/QkC8vNb1Yw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WP4GK1llCz4w2M; Wed, 17 Jul 2024 15:28:09 +1000 (AEST) Date: Wed, 17 Jul 2024 15:28:05 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index Message-ID: References: <20240717045223.2309975-1-david@gibson.dropbear.id.au> <20240717045223.2309975-3-david@gibson.dropbear.id.au> <20240717072018.267421a9@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WEC/OF5lY8RAnzdE" Content-Disposition: inline In-Reply-To: <20240717072018.267421a9@elisabeth> Message-ID-Hash: ELY3FL5EGH2EXBH7SCZPADROPPWKDCB4 X-Message-ID-Hash: ELY3FL5EGH2EXBH7SCZPADROPPWKDCB4 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --WEC/OF5lY8RAnzdE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 17, 2024 at 07:20:17AM +0200, Stefano Brivio wrote: > On Wed, 17 Jul 2024 14:52:19 +1000 > David Gibson wrote: >=20 > > @@ -164,17 +164,17 @@ struct flow_common { > > =20 > > /** > > * struct flow_sidx - ID for one side of a specific flow > > - * @side: Side referenced (0 or 1) > > + * @side: Index of side referenced (0 or 1) > > * @flow: Index of flow referenced >=20 > Nit (I can fix this up on merge, and I didn't finish reviewing yet): > the comment to the struct should also use sidei/flowi. If this is the only issue, go ahead and fix on merge. If there are any more nits I'll make a new spin. >=20 > > */ > > typedef struct flow_sidx { > > - unsigned side :1; > > - unsigned flow :FLOW_INDEX_BITS; > > + unsigned sidei :1; > > + unsigned flowi :FLOW_INDEX_BITS; > > } flow_sidx_t; >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --WEC/OF5lY8RAnzdE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaXVmQACgkQzQJF27ox 2Gdf1w/+NgXyEEZt/7OzAcr5gaX8N6AIx165MPaDG8wPx0Yw7rQoNZ8zlpAm0tsI ozXpfEaXn9c8a9yzXTC+XWGA+HiQcbpvuEBSXtBoHiDgEKzKeM8y7elaDYQS9H7D cEN5AHBc4OMG4Q/geOnGRLeTev5B3dq+GqQvpwGip/yfwnc92uzUuuaWEyyOWiqz +MTjBfSiXIfOjFunlc9Xu7cL3fYSB0eu13riyRcQ+IohzvzJG5fM3yH4Sigp/PTc 9B3M/EM5esKaJWFCt9OCHfa6Gaktv09hTrJP5lQkjVSPvXzhJPdtGuHUL+F/9iKP XG526y99Qr45aJtmDcBB4RH+JLpxSMBY4BIS6AzTq9wLYvjCTSRweherxbGqb86J gGpsL8QeLQoEIjZFdP4Q3cGe6GaPJcY4ezpw9V4kEwO/qSdl2qA99o6I6S2kMtoq TeGsO3QhkEfv45vCdgBt8rE3N+njpKF0nubwiawjwzybDBAn7xjSgluWCXi/gkcX FB1OF2S5xEwsB/LAJ/8nNRAkj51OpHhuIbKBDli79Iu7pAzvfxId0YeotNw1lMHe 5O+hoy6PhG4hrVClTvZAzhdi1NPp188QIioF30N8Il38KxihCUKTWbRbWoBsx1a2 A2GzDG7/rrP+/IuZteUUkTEFd1OjjW/EmjN/RWXkfu8AcnHPN2w= =ozYe -----END PGP SIGNATURE----- --WEC/OF5lY8RAnzdE--