From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 841435A004E for ; Wed, 17 Jul 2024 07:50:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1721195439; bh=5ShZWJQGW1BgzrSZlUPmNZaTFJBwgeYQZsz0kBayEek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qOvEVHLTNCpaLnaiWEFCsDGTWFZoZbKMOg8IVv1CtVJ6zsvZQ+NGfbVg6W6MJeX/C yTlbSnRO0T8uwjwC384utPfJairQ/soPFb23+extSASlqPKsrEyC6VsmZEhEtEYjiO S8qp/o5s+ia8ZRxHMl1DzkmKba922eS0AE9kuZX4i2XHe+iYogkeVAsl4Uius3bTAl 7eCEYHjaoMHYsv03s5L8VLQYJEl+fISBgSxFxBN6YbEcH90j+b892z/eMxxLx4a7uK zcMMm7D3X7hePCJFsHvMF8sQoY/maiIFGsIYx0k/jyRNOWwU0rOhkE6Eow1LjmHWBS UxHcE5TgU6C9g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WP4mH3MNLz4wbh; Wed, 17 Jul 2024 15:50:39 +1000 (AEST) Date: Wed, 17 Jul 2024 15:50:32 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index Message-ID: References: <20240717045223.2309975-1-david@gibson.dropbear.id.au> <20240717045223.2309975-3-david@gibson.dropbear.id.au> <20240717072018.267421a9@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+Q2J+jjVXoqfWTOT" Content-Disposition: inline In-Reply-To: Message-ID-Hash: 3LRB6F4NJNVHW37B6IT5UJ3FLROVG6MJ X-Message-ID-Hash: 3LRB6F4NJNVHW37B6IT5UJ3FLROVG6MJ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --+Q2J+jjVXoqfWTOT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 17, 2024 at 03:28:05PM +1000, David Gibson wrote: > On Wed, Jul 17, 2024 at 07:20:17AM +0200, Stefano Brivio wrote: > > On Wed, 17 Jul 2024 14:52:19 +1000 > > David Gibson wrote: > >=20 > > > @@ -164,17 +164,17 @@ struct flow_common { > > > =20 > > > /** > > > * struct flow_sidx - ID for one side of a specific flow > > > - * @side: Side referenced (0 or 1) > > > + * @side: Index of side referenced (0 or 1) > > > * @flow: Index of flow referenced > >=20 > > Nit (I can fix this up on merge, and I didn't finish reviewing yet): > > the comment to the struct should also use sidei/flowi. >=20 > If this is the only issue, go ahead and fix on merge. If there are > any more nits I'll make a new spin. Actually, never mind. I discovered I hadn't rebased onto the latest and there's a conflict, so I'll respin anyway. > > > */ > > > typedef struct flow_sidx { > > > - unsigned side :1; > > > - unsigned flow :FLOW_INDEX_BITS; > > > + unsigned sidei :1; > > > + unsigned flowi :FLOW_INDEX_BITS; > > > } flow_sidx_t; > >=20 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --+Q2J+jjVXoqfWTOT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaXW6cACgkQzQJF27ox 2GdRNhAAnUFFLgS1pWrIyiqqAoNTY9j4Y0VYRuPPx28dqRc4h4mfnCw/YT5QA4GM udkbjBd3Icr8Z9mQqo5BAldw9pnj/ayIPztXhHm+TrvkuJJpjz7fLDefzV2xnq0L JAAtvgYhk+GdrG3dWfFpn3i8By7ZhwcQVhr8Xh8yQtf2zxBkgXpn8OVFRPSOBX4S k1005tFz9m/lqTspD0Cv5fwBm4Z2viwOHZTtGDhwrbFkmhObydoVdAAlxjzuCouE /b3EY3KYl4+03Rv8AhMv3iXuUnuER5EfiN7v10UDfJovUKqAzNZ1WR0DGHhP0FK4 XBebbdFenxY5Y1uffHbUfTkCg7X0CaelLVrCm/84XbF06y7y9g3RS0b/BIJEcbia G53VFI6beLndNfwT8+4Kx6TqTs+eEbRm8lQ05xS49vhYL0FYQR2Ov2DV1o5/A6gy 9DhebFsLomcuULcA0US7FCejI1gwKNQo0uUNS4ZWnJbRl0SZJ/76aUSDiDhU+77w bKs3mJDkVBYG6sgSZmg9FqQMt2UKXqF++RdNVXpCpJJfSwNZBfx0dudJFnbI/GF8 2+CRxfzGt8AheEtRl2Xoy4wfreO1whQyLs2yiPVb9bk5N2LB9k3AirFsl2nowKxY m1UfAxAs6XCp5Jlj3MmfLe7MBc8985hwAgHhPOdX6iWjzTzTPeI= =Guk7 -----END PGP SIGNATURE----- --+Q2J+jjVXoqfWTOT--