From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index
Date: Wed, 17 Jul 2024 17:27:29 +1000 [thread overview]
Message-ID: <ZpdyYQCp1JDUq0Rr@zatzit> (raw)
In-Reply-To: <20240717092029.0036d1ce@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]
On Wed, Jul 17, 2024 at 09:20:42AM +0200, Stefano Brivio wrote:
> On Wed, 17 Jul 2024 15:50:32 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > On Wed, Jul 17, 2024 at 03:28:05PM +1000, David Gibson wrote:
> > > On Wed, Jul 17, 2024 at 07:20:17AM +0200, Stefano Brivio wrote:
> > > > On Wed, 17 Jul 2024 14:52:19 +1000
> > > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > > >
> > > > > @@ -164,17 +164,17 @@ struct flow_common {
> > > > >
> > > > > /**
> > > > > * struct flow_sidx - ID for one side of a specific flow
> > > > > - * @side: Side referenced (0 or 1)
> > > > > + * @side: Index of side referenced (0 or 1)
> > > > > * @flow: Index of flow referenced
> > > >
> > > > Nit (I can fix this up on merge, and I didn't finish reviewing yet):
> > > > the comment to the struct should also use sidei/flowi.
> > >
> > > If this is the only issue, go ahead and fix on merge. If there are
> > > any more nits I'll make a new spin.
> >
> > Actually, never mind. I discovered I hadn't rebased onto the latest
> > and there's a conflict, so I'll respin anyway.
>
> It's trivial, just a bit of fuzz on 1/6, no need as far as I'm
> concerned.
Ok. Well go ahead and apply then, if you have no additional revisions
to suggest.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-07-17 11:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 4:52 [PATCH 0/6] Of course there are more flow table preliminaries David Gibson
2024-07-17 4:52 ` [PATCH 1/6] flow, icmp, tcp: Clean up helpers for getting flow from index David Gibson
2024-07-17 4:52 ` [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index David Gibson
2024-07-17 5:20 ` Stefano Brivio
2024-07-17 5:28 ` David Gibson
2024-07-17 5:50 ` David Gibson
2024-07-17 7:20 ` Stefano Brivio
2024-07-17 7:27 ` David Gibson [this message]
2024-07-17 4:52 ` [PATCH 3/6] flow: Introduce flow_foreach_sidei() macro David Gibson
2024-07-17 4:52 ` [PATCH 4/6] tcp_splice: Use parameterised macros for per-side event/flag bits David Gibson
2024-07-17 4:52 ` [PATCH 5/6] doc: Test behaviour of closing duplicate UDP sockets David Gibson
2024-07-17 4:52 ` [PATCH 6/6] doc: Extend zero-recv test with methods using msghdr David Gibson
2024-07-17 15:06 ` Stefano Brivio
2024-07-17 15:07 ` [PATCH 0/6] Of course there are more flow table preliminaries Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpdyYQCp1JDUq0Rr@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).