From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 471BB5A004E for ; Wed, 17 Jul 2024 13:45:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1721216737; bh=E28pOtBa8DP66cFOfP4bSwebRFzMyiR1hf5hRLwvrIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TH+eFCsHH5uMHcFGpJtmxahKu3k/NkOx884dn2dxOr/q7ywV2K1+JbFbV1G3clTA7 9j5X5a04L3eGCOMUTXJXqGenQx7tYwbMD3AtDY0dHdN4OGhb+pmqy9dmoHawwQpunW suJ6o0F8iOKI9tfJohn06IaAEzIUZ1wspcH69c17qoMG3j0HFe0PE5LOn0XuA+t4iy vDBoXxmB/LS/uLfFzJ/Hd3pyFaGi3F1P88BfzCUJGFWLLulWdyFajIcKIv6Y7iLwAF 0xmQsohq9AqD3I0Xje58TU0PJ/K+ej9gOqplVQGIKdueHpF0eZdFe4wQXUH+9oCP+4 Bs7LF6P+DuMwQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WPDds1lzzz4w2N; Wed, 17 Jul 2024 21:45:37 +1000 (AEST) Date: Wed, 17 Jul 2024 17:27:29 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index Message-ID: References: <20240717045223.2309975-1-david@gibson.dropbear.id.au> <20240717045223.2309975-3-david@gibson.dropbear.id.au> <20240717072018.267421a9@elisabeth> <20240717092029.0036d1ce@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3Nfz73Xrr0fwPgT/" Content-Disposition: inline In-Reply-To: <20240717092029.0036d1ce@elisabeth> Message-ID-Hash: SV7AMEZOO6CFXCA7YUDEZ4FMQPVDZ6ZM X-Message-ID-Hash: SV7AMEZOO6CFXCA7YUDEZ4FMQPVDZ6ZM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --3Nfz73Xrr0fwPgT/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 17, 2024 at 09:20:42AM +0200, Stefano Brivio wrote: > On Wed, 17 Jul 2024 15:50:32 +1000 > David Gibson wrote: >=20 > > On Wed, Jul 17, 2024 at 03:28:05PM +1000, David Gibson wrote: > > > On Wed, Jul 17, 2024 at 07:20:17AM +0200, Stefano Brivio wrote: =20 > > > > On Wed, 17 Jul 2024 14:52:19 +1000 > > > > David Gibson wrote: > > > > =20 > > > > > @@ -164,17 +164,17 @@ struct flow_common { > > > > > =20 > > > > > /** > > > > > * struct flow_sidx - ID for one side of a specific flow > > > > > - * @side: Side referenced (0 or 1) > > > > > + * @side: Index of side referenced (0 or 1) > > > > > * @flow: Index of flow referenced =20 > > > >=20 > > > > Nit (I can fix this up on merge, and I didn't finish reviewing yet): > > > > the comment to the struct should also use sidei/flowi. =20 > > >=20 > > > If this is the only issue, go ahead and fix on merge. If there are > > > any more nits I'll make a new spin. =20 > >=20 > > Actually, never mind. I discovered I hadn't rebased onto the latest > > and there's a conflict, so I'll respin anyway. >=20 > It's trivial, just a bit of fuzz on 1/6, no need as far as I'm > concerned. Ok. Well go ahead and apply then, if you have no additional revisions to suggest. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --3Nfz73Xrr0fwPgT/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmaXcmAACgkQzQJF27ox 2Gej8BAAluB1ZXqoLkRfAsQbabKjCa2/6s7i4QHKCV3T3Ff/egJzb7YaAzJfn6JZ eUeRRXBy2b9wJq8HEFsUXkBX10hdpWJjz2N2jcCaxeW4UqVAWk4ObP2l4mG8u1xC dZcyaWW4KHGwhTfFyy4mcDrRYHqEF9Ysyec2FkLGs09fQq67WYQYZV/66l265Cs8 khrHcveApl5s82c0j50Zjj1tCZRq8dajiFZPdzVcY/xi73jNZjR3oR0dN6PYMLkU RMa0eY2G5ag+k9moMkkWkJa+pDsF5V4zlMugQ2PHwD3hmCcNl4A7wvvEA14mubdE SLMOcD7a6XPREQZg2BVXKVeaJsmolGgC4FldpPTGY7J53cjW1sBCrcE0Zo2+vag9 HVi5Bz18t4m79qCOdcvo5CWTHNoZmlLinJpdlurvES/P5KXlYr/lorhuUK49rgdS 1awP4dohSz16oRdt857G+fBHgcgsoaUKlZomIIltVWNeKNmsz9gmIEfm9lpJ9pBI n6gTIfxBhnQ6NsOWW/NWMF3c5uUxU3tmfiWwZLYzxtl9moeOuFXu1m6NYSCXR9xy GCiAqgGv4ECiD6i0d65b7mRgC5wz0DUyAX0C9CF9UJE9sIm0igmQKu43Ut6Iprxq tf80dDhJ4O3RL5VKCvMmpLJV2VRqgczkxhiICrPrnfBmI7nJl0s= =t9a/ -----END PGP SIGNATURE----- --3Nfz73Xrr0fwPgT/--