From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id ADEC25A031E for ; Thu, 25 Jul 2024 05:47:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1721879255; bh=uIZXYc/Iwq1fEYruecZX3rr6pa04DG5KnUMrGFjo1Nw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vrfw+AvqrcZMx5/YKgG7CHICo4vg9Yuod0FFgFpP4LAM0F7bRE6+zQfBcj+tBAVGI LOJPoczgdIHaRVM/nFT8MPBzlO41JweMQfsO7u1qjVyTTwGzDx8XBBKT/e1FmK9Qh3 AZrJllBpRIpp2AoapQ7mrIlxeGSg2jDh46zsr7nWZn9/xzlWmqDvodYmtOqaqo0uYX gjBcPughSuCHs0hhej2vGvWtNVfz8yx3GgSeciFySGFyNz8HfVEKCYWiSg568yREcZ eizpWyxd2M5bp6HurqHyU/6gFBlJg55TMP7nK6bQWmn8UIRca7PnAvJ9V4lxiFFg/f 79lwhVCPUbX+A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WTxfb4BJgz4x1V; Thu, 25 Jul 2024 13:47:35 +1000 (AEST) Date: Thu, 25 Jul 2024 13:22:00 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 02/11] tcp: Change SO_PEEK_OFF support message to debug() Message-ID: References: <20240724215021.3366863-1-sbrivio@redhat.com> <20240724215021.3366863-3-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hj30Yq1OSGhhi45r" Content-Disposition: inline In-Reply-To: <20240724215021.3366863-3-sbrivio@redhat.com> Message-ID-Hash: MTOVA2P6UPXJKOS4RCVBDTTELSYPWWB6 X-Message-ID-Hash: MTOVA2P6UPXJKOS4RCVBDTTELSYPWWB6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Hj30Yq1OSGhhi45r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 24, 2024 at 11:50:08PM +0200, Stefano Brivio wrote: > This: >=20 > $ ./pasta > SO_PEEK_OFF not supported > # >=20 > is a bit annoying, and might trick users who face other issues into > thinking that SO_PEEK_OFF not being supported on a given kernel is > an actual issue. >=20 > Even if SO_PEEK_OFF is supported by the kernel, that would be the > only message displayed there, with default options, which looks a bit > out of context. >=20 > Switch that to debug(): now that Podman users can pass --debug too, we > can find out quickly if it's supported or not, if SO_PEEK_OFF usage is > suspected of causing any issue. >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tcp.c b/tcp.c > index c031f13..c0820ce 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -2524,7 +2524,7 @@ int tcp_init(struct ctx *c) > =20 > peek_offset_cap =3D (!c->ifi4 || tcp_probe_peek_offset_cap(AF_INET)) && > (!c->ifi6 || tcp_probe_peek_offset_cap(AF_INET6)); > - info("SO_PEEK_OFF%ssupported", peek_offset_cap ? " " : " not "); > + debug("SO_PEEK_OFF%ssupported", peek_offset_cap ? " " : " not "); > =20 > return 0; > } --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Hj30Yq1OSGhhi45r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmahxNcACgkQzQJF27ox 2GfcTw//W4UANVJDYDxjS2nGD/J1wSHhQpZIrmIzWD61SPjmZOugp8G4pjetBDr6 fJhDHtk7VDxLLgJgnksRsWVrjt9OYlgsLq1LfWQms/ciD4li8gn2NxW1Sd7owpYY mmo4UT0q8lZ2kBafjmkgrZiRMuvKjKTnRgsptzgoL+HJEW/0xOp48RB9OfVqOnpz 41x+xgR3QJQS0Mty2mpWbwhtAxEeBLnU+N63wiKRBado2MIaXJTe1k+LYSU3+XKR l7Swn2xE6+TlmFnZaoB6fagJolGSd2OEbn/vw+4OjP/Sfal+K+/Cow9WLSx+Qv9i RWua6sdfUQvBB5uBvn4x+/ajmHq9R2zYMna4x0BD57YW6KxifnJFQCe/TuT5YU9z 83Sw1aI/BepYkt1thbTxJ2Cj4HIkPgMj+l9fTZq28pIQEYsDTsKxd/DHKhjsCwQB XkqTpVuDfDfRQppJkK0dvskWaH0OPbMk1KYk2HCkzGK8a5PQjQe+cxU6aQybGRyn Lmtx7njm7YaSN5JFEolAzIB1ByzMYY2iJDlzG87Alv/DyehjImvy8P90m4nyys8+ ibCQbRuls/sgtjEPo481fw2FGXorbZyes955Ir2Zd/HxP8HVP6y2p9kPM7jb7qLR mJGUihoQ06E3L8ifdMlFJnzk4oJJ24ce7RmpWQ7ggs7twSLAnOs= =k5La -----END PGP SIGNATURE----- --Hj30Yq1OSGhhi45r--