From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=fail reason="key not found in DNS" header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202312 header.b=Lr73OA1v; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 1EC795A0276 for ; Thu, 15 Aug 2024 05:43:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1723693394; bh=+4j3ZZ6PZNKGMOO9FJfqTOwdsHc2zcc9SZfa5sRgS1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lr73OA1vSZ8eJ0DyFv4+U7V+bPjXJlq/epMxQRVrp8IJqKZlfzHhEcK+rn7CsyfnX XA6Xgtq6Hzn3SRRrbGmtkL7ez5GTz/V5udJSsNH1eRbNRoaHxKfEAFZext4tSiGHiu dELLOQH663YwbK3vfLqWkTtxWCelI9LWyVdX2O1u7n6bwZrU1JsLPcIkBsHoRtr8ZR xGR8fgAdpXEM0nwqV2pwVxCA66K8pj9PutYoUt+1Z0mvqznigIv2cD6+J3tPjIsvoo JuW82sEuB+HaFemSTHDcRN5d2NqHx/ib0IML+Q5y9Igg+O1Il6cJllmlZo9SJZqi9i YR5O+yBs+5h+A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WkrYt03Z4z4x11; Thu, 15 Aug 2024 13:43:14 +1000 (AEST) Date: Thu, 15 Aug 2024 12:39:50 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 1/7] netlink: Fix typo in function comment for nl_addr_get() Message-ID: References: <20240814225429.3707908-1-sbrivio@redhat.com> <20240814225429.3707908-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+zmiKTjauMU6h0Bv" Content-Disposition: inline In-Reply-To: <20240814225429.3707908-2-sbrivio@redhat.com> Message-ID-Hash: FQILRGOAFHVJFBSR7IWK7HVGKOZO2R4E X-Message-ID-Hash: FQILRGOAFHVJFBSR7IWK7HVGKOZO2R4E X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --+zmiKTjauMU6h0Bv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 15, 2024 at 12:54:23AM +0200, Stefano Brivio wrote: > Signed-off-by: Stefano Brivio Heh. Reviewed-by: David Gibson > --- > netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/netlink.c b/netlink.c > index 093de26..e6a315e 100644 > --- a/netlink.c > +++ b/netlink.c > @@ -682,7 +682,7 @@ int nl_route_dup(int s_src, unsigned int ifi_src, > * @prefix_len: Mask or prefix length, to fill (for IPv4) > * @addr_l: Link-scoped address to fill (for IPv6) > * > - * Return: 9 on success, negative error code on failure > + * Return: 0 on success, negative error code on failure > */ > int nl_addr_get(int s, unsigned int ifi, sa_family_t af, > void *addr, int *prefix_len, void *addr_l) --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --+zmiKTjauMU6h0Bv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAma9anEACgkQzQJF27ox 2Gc6lA/9GcXQPhFFZm3zbegWyb8+pFIxciRSaAqxMOBkur1z7YsIJjxaqzHMwWU4 0jyqhJ4xubHyc9kRKU9Gn0rCW2XqNp/OX7S6hCBqwVyNoQmzIE8NzRQsggMyWq89 nAvbG9Qwt3Q7iJUWyvh8ovER75wEU/p2bly1EZhjz5JX1Pgho7wqoYa/3UK8JNf5 +dIrGQdPQO/30LkY5XP3gyUr2PVPLnelZb5C1f19++uQ/k+BaV1mw5oxF6fmCs4E byTTO4pv11KRccG4YHum5CrdM47FRz06yrCZxI1ct0wH8imxiI9fxbzPO9Ozuc9w ixPy/2TEy+eE0QCi0D/eO4nWfDghxMTKtA3Z7Cs7rn10ys9iXj+KDV63tQXKp1K/ 0fkPW/Ui6GadR2xIqjRFFbXXFNgLACar3Fv7aPAPUW0wYzzk3vDEGADXCPLvkmy2 OEJch55JbCa0qa4ADPMeSPkKl48XoxiyT0cN5ZQQLWG37Y8IIuX+rlg4EaB2vwz0 m//U+JqLZA3BwzaSNz9Q3CfoKT8Ki8ke63vqjaFCXhY4HCZ6BnzqEuAD1QnM1Ryl G0l5dKjLNm6Mk+eSTKJw4NhWyDRCKBqWh+tEdEbQ1yVm2jBD/l483CZ8gMffGz+U A0jn/ne9EHkX8upmGOy8i/GrWs+palIrjaX9qxc6c6AnGRBWAsM= =FYzB -----END PGP SIGNATURE----- --+zmiKTjauMU6h0Bv--