From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=fail reason="key not found in DNS" header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202312 header.b=Yh2ZLON4; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 6DFEF5A026E for ; Thu, 15 Aug 2024 07:42:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1723700528; bh=UHvt1IXcYQIq3eLQn8pRRWLZ3KRWRw/hBte29D5guiE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yh2ZLON4jFl7KuLqAuMnA06fnC+2t05wih893WTaMOvUv6aHahWoqspfcKd/4i3pr zlt88lniFK8dgiE85Ui+Mk8gjccxwsGsSCsx+n3msfMyxnXQfBCopWV6pXjrJ/FpS1 ZWV65lqEpbxAq2d5lb7dFKT2Y4qdnrGJDhMgcBY8vqlTOUW2dMfSywA3SJ98AreVo1 V5uU18wcVtRr9J2DDV/2ZSy375H/vRvHoZXZ28r2DVk7dbdtPUWP7U+n1ZEOD9W/cl d34YYL6Wkkf/gBbQ/a1nuZNrQst+f+uhoZA8LIGkOI7bMUVYMlnyfLeNq66B0pp6po TRBvdRnrZlPCg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WkvC449rhz4x1V; Thu, 15 Aug 2024 15:42:08 +1000 (AEST) Date: Thu, 15 Aug 2024 15:01:53 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 3/3] fwd: Rework inconsistencies in translation of inbound flows Message-ID: References: <20240812095355.1721876-1-david@gibson.dropbear.id.au> <20240812095355.1721876-4-david@gibson.dropbear.id.au> <20240812235117.6a48a817@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sJ9ZB3nByn+Smd/X" Content-Disposition: inline In-Reply-To: <20240812235117.6a48a817@elisabeth> Message-ID-Hash: BGOWECX5BMWE5NZ25HAGKPXQ5IMELAEF X-Message-ID-Hash: BGOWECX5BMWE5NZ25HAGKPXQ5IMELAEF X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --sJ9ZB3nByn+Smd/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 12, 2024 at 11:51:17PM +0200, Stefano Brivio wrote: > I applied up to 2/3, I just have one doubt here, and a nit: >=20 > On Mon, 12 Aug 2024 19:53:55 +1000 > David Gibson wrote: >=20 > > We usually avoid NAT, but in a few cases we need to apply address > > translations. The current logic for this on inbound flows has some > > inconsistencies: > >=20 > > * For IPv4 (but not IPv6) we translated unspecified source addresses >=20 > ...I know we already talked about this, but 0.0.0.0/8 is not just > unspecified, it also means "this host on this network" (RFC 6890, > 2.2.2), and that's the reason for this apparent inconsistency (:: > doesn't). By the way, somebody was reminded of this just recently: Good point. I've changed that behaviour for the next spin. And added comments about this for the next sucker who notices the apparent inconsistency :). --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --sJ9ZB3nByn+Smd/X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAma9i8AACgkQzQJF27ox 2GeGkBAAm/8kM4M/vFuY5YGPl2nh9apyECIYKoP+EfvC46owBGbzerBbrFNwou/c 0t0+4ptywIgpngn1AhQssbX+1z0y6CMeoZBbOx6NWIjA+iy2j56x2p0bFKk055lA +A7IuEt8E91kj6bXccLacwMKDnrknJBxmUTELvuPo8k1ONyfXnZZg8OHOfkCI46z KrK4vM8padUJ7v3u4Qig0qnELP4PjQ8tqxjG0SLlNV5g/Cp2fD/f7Sug/iipTgiC qBHlrYO9ZSgghNlU72hfljWnhl9z8ipPkQE0pCsVuL1HMzzl7NP1DctitN5y1BQ9 w7K5Cf0hmfQqkVGhLIGdjYhHgNL4hkR7VpLw0o4KAqHHnXnHFeiOI8j5PcE5Mkc3 frEfRDdJMsI/2qDyyybp+LcRcYh9yZZnJgckVLhEvgBtffWsgyC1iWVQCBUwQ6HO a/arEM/svqRfvUus0h3DLvC2CEHDvBLsxU9UcZ3tNfn98+vf+lkhZcRzLRgdm2mp FI4zU4dUUv1Bu4xw/C3iK2UsififdTGQlNa/dbK2RbFcG5qT7AhcTry56TtJv3H8 +5gLChU8eHA47koOikJhGBLunLHLW2zyRXaAg+fb2zkoRvHzuP0p0iG2OCRg2/+l yf5HvLIWcXawNJJF7ebFivsvg2FLPnPf31AgsUBTxAa6cGsrKqQ= =B9hx -----END PGP SIGNATURE----- --sJ9ZB3nByn+Smd/X--