From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH 00/16] Cleanups and fixes related to "our" addresses
Date: Wed, 14 Aug 2024 15:03:26 +1000 [thread overview]
Message-ID: <Zrw6njXQ1oFgl3Nl@zatzit.fritz.box> (raw)
In-Reply-To: <20240814043050.4177037-1-david@gibson.dropbear.id.au>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On Wed, Aug 14, 2024 at 02:30:34PM +1000, David Gibson wrote:
> There are some places where we have addresses that are "ours" in the
> sense that they're local to passt on at least one interface. But in
> some cases it wasn't clear which addresses those were or how to use
> them. Make a number of renames, cleanups and small fixes related to
> that.
>
> ..and also an assortment of slightly related things that I encountered
> along the way.
>
> Note that 1/16 is an important fix for a bug I introduced in the last
> series I sent. For the rest, apply as many as you're happy with and
> I'll respin what's left as necessary.
Ugh. I've found several more problems in the series (though mostly
just incorrect comments). Review if you want, but don't apply please.
I'll send a new spin soon.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-08-14 5:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 4:30 [PATCH 00/16] Cleanups and fixes related to "our" addresses David Gibson
2024-08-14 4:30 ` [PATCH 01/16] conf: Don't ignore -t and -u options after -D David Gibson
2024-08-14 12:18 ` Stefano Brivio
2024-08-14 4:30 ` [PATCH 02/16] treewide: Use "our address" instead of "forwarding address" David Gibson
2024-08-14 4:30 ` [PATCH 03/16] util: Helper for formatting MAC addresses David Gibson
2024-08-14 4:30 ` [PATCH 04/16] treewide: Rename MAC address fields for clarity David Gibson
2024-08-14 4:30 ` [PATCH 05/16] treewide: Use struct assignment instead of memcpy() for IP addresses David Gibson
2024-08-14 4:30 ` [PATCH 06/16] conf: Use array indices rather than pointers for DNS array slots David Gibson
2024-08-14 4:30 ` [PATCH 07/16] conf: More accurately count entries added in get_dns() David Gibson
2024-08-14 4:30 ` [PATCH 08/16] conf: Move DNS array bounds checks into add_dns[46] David Gibson
2024-08-14 4:30 ` [PATCH 09/16] conf: Move adding of a nameserver from resolv.conf into subfunction David Gibson
2024-08-14 4:30 ` [PATCH 10/16] conf: Correct setting of dns_match address in add_dns6() David Gibson
2024-08-14 4:30 ` [PATCH 11/16] conf: Treat --dns addresses as guest visible addresses David Gibson
2024-08-14 4:30 ` [PATCH 12/16] conf: Remove incorrect initialisation of addr_ll_seen David Gibson
2024-08-14 4:30 ` [PATCH 13/16] util: Correct sock_l4() binding for link local addresses David Gibson
2024-08-14 4:30 ` [PATCH 14/16] treewide: Change misleading 'addr_ll' name David Gibson
2024-08-14 4:30 ` [PATCH 15/16] Clarify which addresses in ip[46]_ctx are meaningful where David Gibson
2024-08-14 4:30 ` [PATCH 16/16] Initialise our_tap_ll to ip6.gw when suitable David Gibson
2024-08-14 4:39 ` David Gibson
2024-08-14 5:03 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zrw6njXQ1oFgl3Nl@zatzit.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).