public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, Paul Holzinger <pholzing@redhat.com>
Subject: Re: [PATCH v4 4/7] netlink, pasta: Disable DAD for link-local addresses on namespace interface
Date: Sat, 17 Aug 2024 19:45:24 +1000	[thread overview]
Message-ID: <ZsBxNAtT39aaMY3i@zatzit> (raw)
In-Reply-To: <20240817084308.2734874-5-sbrivio@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On Sat, Aug 17, 2024 at 10:43:05AM +0200, Stefano Brivio wrote:
> It makes no sense for a container or a guest to try and perform
> duplicate address detection for their link-local address, as we'll
> anyway not relay neighbour solicitations with an unspecified source
> address.
> 
> While they perform duplicate address detection, the link-local address
> is not usable, which prevents us from bringing up especially
> containers and communicate with them right away via IPv6.
> 
> This is not enough to prevent DAD and reach the container right away:
> we'll need a couple more patches.
> 
> As we send NLM_F_REPLACE requests right away, while we still have to
> read out other addresses on the same socket, we can't use nl_do():
> keep track of the last sequence we sent (last address we changed), and
> deal with the answers to those NLM_F_REPLACE requests in a separate
> loop, later.
> 
> Link: https://github.com/containers/podman/pull/23561#discussion_r1711639663
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-08-17  9:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-17  8:43 [PATCH v4 0/7] Prevent DAD for link-local addresses in containers Stefano Brivio
2024-08-17  8:43 ` [PATCH v4 1/7] netlink: Fix typo in function comment for nl_addr_get() Stefano Brivio
2024-08-17  8:43 ` [PATCH v4 2/7] netlink, pasta: Split MTU setting functionality out of nl_link_up() Stefano Brivio
2024-08-17  8:43 ` [PATCH v4 3/7] netlink, pasta: Turn nl_link_up() into a generic function to set link flags Stefano Brivio
2024-08-17  8:43 ` [PATCH v4 4/7] netlink, pasta: Disable DAD for link-local addresses on namespace interface Stefano Brivio
2024-08-17  9:45   ` David Gibson [this message]
2024-08-17  8:43 ` [PATCH v4 5/7] netlink, pasta: Fetch link-local address from namespace interface once it's up Stefano Brivio
2024-08-17  8:43 ` [PATCH v4 6/7] pasta: Disable neighbour solicitations on device up to prevent DAD Stefano Brivio
2024-08-17  8:43 ` [PATCH v4 7/7] netlink: Fix typo in function comment for nl_addr_set() Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsBxNAtT39aaMY3i@zatzit \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).