On Sun, Aug 18, 2024 at 05:45:00PM +0200, Stefano Brivio wrote: > On Fri, 16 Aug 2024 15:39:44 +1000 > David Gibson wrote: > > > c->mac isn't a great name, because it doesn't say whose mac address it is > > and it's not necessarily obvious in all the contexts we use it. Since this > > is specifically the address that we (passt/pasta) use on the tap interface, > > rename it to "our_tap_mac". Rename the "mac_guest" field to "guest_mac" > > to be grammatically consistent. > > Wouldn't "our_mac" suffice? Maybe. This is supposed to emphasise that this is used on PIF_TAP - we also (usually) have a MAC address on the host interfaces, though we don't really need to care about it. > Even the day we get to support other types of link (well, "tap" for a > guest is already not a tap, I know...), or especially multiple links at > the same time, I guess we will still want to use a single MAC address. -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson