From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=fail reason="key not found in DNS" header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202312 header.b=Z+PeNgmT; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 79B805A0275 for ; Mon, 19 Aug 2024 03:39:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1724031595; bh=gpmAC9f+QbZem2TCAZOc80Q1UhL/1VpEh7nQklbzv/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z+PeNgmTL0BXpk7VoKOLv4XCBK1PRgrzXBCt4RYDpeqQvYPoFszvb3q5wz5GCkzJ4 x7lZd2j3tFZ8WyqL8fktJpbVmLB941d2aEy8ZJGTN17dC3wyv21tg9vVzkTQlTudf9 xh1PUuJStU/GJXF1gTp8h8hK1otO5qxzv/Gu0Dk93e5ZscpVHPBBhsgTaqDlQfTDXM US+AJn/GOUoAtp7IVAIElhyUGG+DyCRfyiPTU8SZ4p84NHU+cR1K+97XAwS3HAGF2e AEATCl02U3+VHY7CEetRCplkyVeA9ES2KPoZPm/WLsuOQ7U05h+ud2ayaTgvv0M82M PZtJS1MEFQlMw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WnFdl2638z4wcl; Mon, 19 Aug 2024 11:39:55 +1000 (AEST) Date: Mon, 19 Aug 2024 11:36:49 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 03/22] treewide: Rename MAC address fields for clarity Message-ID: References: <20240816054004.1335006-1-david@gibson.dropbear.id.au> <20240816054004.1335006-4-david@gibson.dropbear.id.au> <20240818174500.1f7c5c50@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O375y2EmI92unKS5" Content-Disposition: inline In-Reply-To: <20240818174500.1f7c5c50@elisabeth> Message-ID-Hash: MWSAQGZ6L6AYROUWMHLLE4A4LA6YOA3B X-Message-ID-Hash: MWSAQGZ6L6AYROUWMHLLE4A4LA6YOA3B X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --O375y2EmI92unKS5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 18, 2024 at 05:45:00PM +0200, Stefano Brivio wrote: > On Fri, 16 Aug 2024 15:39:44 +1000 > David Gibson wrote: >=20 > > c->mac isn't a great name, because it doesn't say whose mac address it = is > > and it's not necessarily obvious in all the contexts we use it. Since = this > > is specifically the address that we (passt/pasta) use on the tap interf= ace, > > rename it to "our_tap_mac". Rename the "mac_guest" field to "guest_mac" > > to be grammatically consistent. >=20 > Wouldn't "our_mac" suffice? Maybe. This is supposed to emphasise that this is used on PIF_TAP - we also (usually) have a MAC address on the host interfaces, though we don't really need to care about it. > Even the day we get to support other types of link (well, "tap" for a > guest is already not a tap, I know...), or especially multiple links at > the same time, I guess we will still want to use a single MAC address. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --O375y2EmI92unKS5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbCobAACgkQzQJF27ox 2GdvKA/+NL2BXeUy5Yr8CZUcTKyukVPH+Sx39CqGgft0fHsab2ndPYEwUIV0Koep NSgrWBRlDmRpj9/DlaI1EZKDJXdj/W5xjaeDEJSX2vnD22FeLTPMLJf79JiS1cUX hByYWnWyRTGBkBhQUb4hZVr6Vu6H9bgNfYueKt1X9IrGq67PTi91WoMIOwwT3hBb MnFXLVWa3ppb+oc69ta+5RG2xr1Gi9rSuXaQEr03H8fLuq0B1Raftl4BErx/tl86 Ii2iUmk3DxZLFABzdq4/uZEr1sFr9q8EDbVr7MydLjaTH5XCQzN5IZEVzuPpaxEA +ueyIjhad/U63V5xROyPYXUG5ScF37XGX5fNlfbFG5E7v1lfFJukbyTFd1ZT40OA sF85oVxldvZH1WjErmFS5dUy2yyp/fRsPHXT1ddzvOzmOdlVyf/Zvqj07xo0LsZQ OiuaCnlLw8Ln3jKalcKrWzW9wKR5wQjmaMfJqHdPVeX0VtiYTHOapGSIWfv6Gr/L QcvDBH+xNCh8J9UWCDEftp5bobxc2IygnEGE5RYnH54cher9tPNkJcR3DnO2zQAt dqDGPKf0yD+BOk7QaDlJjUJRro8AJFew0onyzcvIKh9hyziIOZQ3LuU8QRdsHfvQ oxZdPJ7hepggMIr9tFpoFekeQDcQfHpOOzOHIS8nORt70K+I9r8= =5y9/ -----END PGP SIGNATURE----- --O375y2EmI92unKS5--