From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=fail reason="key not found in DNS" header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202312 header.b=K5lRVbWo; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 9BFA05A004E for ; Tue, 20 Aug 2024 02:50:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1724114993; bh=E8wS6TNBIuS8HLaJdMYTXpaWfTaIezNFWJZ0tI18GJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K5lRVbWoZ+cYxvfQZG4fhr/8omeW9hhnHchcZ+l8UkjyrvpzHHkEFI3kDhnRIiIec BU/6pNIzGXNka+NmKeTxyRbilcccY/L9MdDH4mW4nKSe8YlNlngVix2eNmMgfvwnV2 kOEym/gE1YaigNnqWiSGuEE89CTOcZcKN0ehlY/yobsIKYqtokfuKRtUma/jeS2XJk AUH+5bVpnDR5Je4TWldG3kbiLMMj6T8e2wjAezaFF9EXtTZRIeJ6c4Tf2pc7pnBjSK C+Ru12zh5G6UANX83m42lJZMnhd4kslaeXOlF4NQ8k8xdLqUW3M31TZntpEJFaJMIq ds9i6RsBWzMHw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WnrTY3xTRz4x2M; Tue, 20 Aug 2024 10:49:53 +1000 (AEST) Date: Tue, 20 Aug 2024 10:48:36 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] tcp, udp: Allow timerfd_gettime64() and recvmmsg_time64() on arm (armhf) Message-ID: References: <20240819231529.1482175-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Igzul8OYzNZ9pJZG" Content-Disposition: inline In-Reply-To: <20240819231529.1482175-1-sbrivio@redhat.com> Message-ID-Hash: GIPTNVO5DK3THYADSMPAEN4FMPFNWK3K X-Message-ID-Hash: GIPTNVO5DK3THYADSMPAEN4FMPFNWK3K X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Faidon Liambotis X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Igzul8OYzNZ9pJZG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 20, 2024 at 01:15:29AM +0200, Stefano Brivio wrote: > These system calls are needed after the conversion of time_t to 64-bit > types on 32-bit architectures. >=20 > Tested by running some transfer tests with passt and pasta on Debian > Bookworm (glibc 2.36) and Trixie (glibc 2.39), running on armv6l. >=20 > Suggested-by: Faidon Liambotis > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1078981 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tcp.c | 2 +- > udp.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tcp.c b/tcp.c > index c542a78..501c56c 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -2143,7 +2143,7 @@ cancel: > * @c: Execution context > * @ref: epoll reference of timer (not connection) > * > - * #syscalls timerfd_gettime i686:timerfd_gettime64 > + * #syscalls timerfd_gettime arm:timerfd_gettime64 i686:timerfd_gettime64 > */ > void tcp_timer_handler(struct ctx *c, union epoll_ref ref) > { > diff --git a/udp.c b/udp.c > index 851881e..f8fd597 100644 > --- a/udp.c > +++ b/udp.c > @@ -460,7 +460,7 @@ static bool udp_sock_recverr(int s) > * @events: epoll events bitmap > * @mmh mmsghdr array to receive into > * > - * #syscalls recvmmsg i686:recvmmsg_time64 > + * #syscalls recvmmsg arm:recvmmsg_time64 i686:recvmmsg_time64 > */ > static int udp_sock_recv(const struct ctx *c, int s, uint32_t events, > struct mmsghdr *mmh) --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Igzul8OYzNZ9pJZG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbD5+MACgkQzQJF27ox 2GfMQw//Q+UaBZDoNoB6a4YQFad3BA0wqLrm6CcmVTcmXbknZq7KjBgYenY6316K 46qXLI6aNzBL09czaOpvlzplBnwfeaLk7NXQoCUhi3i2JJUdEpurnhe6Qlm44FVJ XCVTFOmbfZL+K3VMgPH1qxWlDBFbGPzfaWhgVFjBpkfyXoUFIHme2X9dfwcL+EA7 dl8Bs+khzQHf9TfX1/MvzsCsA0T0ZZyQqtud4I/cdlOzS+l/uKVIgd3cRQaNK1Gf 8prHi2B80nGnIrcziQqvJbRqQtiW7lHQPGZCR4g5qcdVNtcDF9UiBbRXfIFozDc0 F+ko9vtYmA5TnUiB40y0FwMSyYQjZJiFjcDTDAusXQLcle+mt1X2NFYJ+k9Oblol +K+pfRUZ1bWBLXZgDjyx1beO+aQnglcLY7v+LWLiYKj+5xgUMhj23LOcXLgrKMW0 bZDUX6CrT2Bs9qnOtKqjZ8iO7FSRrEHtOOFnS7tBE9+mIOFZ4WHG/sSzkQ+fXJj2 wlGUfwxRVoX3gf6KVwzCBxwSSSJKpUadpvbt1sQdjahUzXG03zTySJTF72KL0ANG f7ETmW89ZGeChDoARQFRR1WMJyK0C0R4Q22eH3V/NrSiGhq8EJaHmXsDcnTGMsDs VE4TAysyJY/dik8cMeQPQ5n4EKmdHFOSzanIJL1uVMrTzdRHvMQ= =1CWT -----END PGP SIGNATURE----- --Igzul8OYzNZ9pJZG--