Re: [PATCH 4/4] test: Duplicate existing recvfrom() valgrind suppression for recv()

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On Tue, Aug 20, 2024 at 01:14:34AM +0200, Stefano Brivio wrote:
> Some architectures, including i686, actually have a recv() system
> call, not just a recvfrom(), and we need to cover the recv() with
> MSG_TRUNC into a NULL buffer for them as well.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  test/valgrind.supp | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/test/valgrind.supp b/test/valgrind.supp
> index a158394..735b5f6 100644
> --- a/test/valgrind.supp
> +++ b/test/valgrind.supp
> @@ -6,3 +6,12 @@
>     ...
>     fun:tcp_sock_consume
>  }
> +
> +# same as above, for architectures with the recv() system call (at least i686):
> +{
> +   passt_recv_MSG_TRUNC_into_NULL_buffer
> +   Memcheck:Param
> +   socketcall.recv(buf)
> +   ...
> +   fun:tcp_sock_consume
> +}

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]