From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=fail reason="key not found in DNS" header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202312 header.b=YcBb3lFz; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 316615A004C for ; Tue, 20 Aug 2024 02:50:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1724114993; bh=qH0OslsHG9XwNzyA5imbu0HAGegM8SqotU0PO1EiuS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YcBb3lFz6FnSivlwOmMlOfx9T6s4EoOBXsEf8LgFKes7MMf95mUoUt6OiZge+H04z d4xeoLJbPxVbQEctpJxWBem1ZqAmxncaQ4/HcUTdxNhQuiIyRjFZPfrqktcQoPw14Q JYROSz/4vYlMVUMZGo6NGuoOHRBPRO06SB3qdX9wfvZDRVCRWHy5PEKWfMmbopHYle n4AwHPTRx0OLF0YKr2N/ECHtDuC3prW06fwwTOAMoI8SjzVmt7fvZ2IE8iU+rOv8l5 nYfeopOY7IyQ09ypemdDfH0nTVEPha0QNRVsP3Zid9BDRYyoOnlK+V4P3Piv0WuCrJ Lu7fJNqAcCFZQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WnrTY3kSFz4x1s; Tue, 20 Aug 2024 10:49:53 +1000 (AEST) Date: Tue, 20 Aug 2024 10:46:58 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 4/4] test: Duplicate existing recvfrom() valgrind suppression for recv() Message-ID: References: <20240819231434.1481576-1-sbrivio@redhat.com> <20240819231434.1481576-5-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mpybKTOen8bVdqjh" Content-Disposition: inline In-Reply-To: <20240819231434.1481576-5-sbrivio@redhat.com> Message-ID-Hash: IDV3PGRZEFVLMRP4PZONX6QJZCFJJEGT X-Message-ID-Hash: IDV3PGRZEFVLMRP4PZONX6QJZCFJJEGT X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --mpybKTOen8bVdqjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 20, 2024 at 01:14:34AM +0200, Stefano Brivio wrote: > Some architectures, including i686, actually have a recv() system > call, not just a recvfrom(), and we need to cover the recv() with > MSG_TRUNC into a NULL buffer for them as well. >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > test/valgrind.supp | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/test/valgrind.supp b/test/valgrind.supp > index a158394..735b5f6 100644 > --- a/test/valgrind.supp > +++ b/test/valgrind.supp > @@ -6,3 +6,12 @@ > ... > fun:tcp_sock_consume > } > + > +# same as above, for architectures with the recv() system call (at least= i686): > +{ > + passt_recv_MSG_TRUNC_into_NULL_buffer > + Memcheck:Param > + socketcall.recv(buf) > + ... > + fun:tcp_sock_consume > +} --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --mpybKTOen8bVdqjh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbD54EACgkQzQJF27ox 2GfRgQ//bjiOSXlb55A0GGK+AYDPLp8bz5cllcJZszq+QeFGE8RwvB7mcNQ1P9qD HXi7yN1lbx4jg77QBb0vlI4/u0Q5lBhtGHen4UdR5FAwU9loDbwS+R/Tvb0/8KB0 RVgvCQSx+wUJ5aWrDgzbylTVW26p1+NLZ13QzIyZE2FYCLx4H59k0aTM9f9mXeZh thoksXjR5kD3yPtHM0MV9zy0zKm80w+MtLoX+wLDvjBzC64IjxE9pbf41XEbBTZ1 U9+5AotkoLHDSWNnYgXmrQ9tJv6+VfFyDrbUNSFP4mou7mv6g9B12v4reHb5L0Zs NaFqet/5oopfsqfd50dRWQAozVX9TEMavQ7Ab1KqZXZZJTtzhicitMybOocZqZPe RBOUoeIwL3DqrM80UVwaG6HQTAbR+PU9YKQ3kKPGlMV0tuLSMsMwqpWqYHRn4+G9 FzpS4+Gv0NdlQXKP7sPW6UAQUHkpmNx2pfsabdsmT7EgB6CiDL7YkSZHO15DluD6 24SuLtWKeLHLS+KC/m+XEZKvA42vyvl5YAPnvxgmeANv2mBtRcp8oJCL+t8f/7DL 3w0US14qdZMyaRjNS3GlnmJ60L6X87uw5d8qA8jX/iPpwVjl6rlaJPJlMWHKhO1Y MrzecV4wu4AefEJzXANWbt2R1ruH2T1oCPVw7gxHnAEAFPyvHkI= =+dr2 -----END PGP SIGNATURE----- --mpybKTOen8bVdqjh--