From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, lemmi@nerd2nerd.org
Subject: Re: [PATCH 1/2] udp_flow: Add missing unistd.h include for close()
Date: Tue, 20 Aug 2024 10:47:24 +1000 [thread overview]
Message-ID: <ZsPnnJIo8FhyctN-@zatzit.fritz.box> (raw)
In-Reply-To: <20240819231505.1481940-2-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Tue, Aug 20, 2024 at 01:15:04AM +0200, Stefano Brivio wrote:
> For some reason, this is reported only with musl, and older glibc
> versions (2.31, at least).
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> udp_flow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/udp_flow.c b/udp_flow.c
> index b1133c0..1ff59a9 100644
> --- a/udp_flow.c
> +++ b/udp_flow.c
> @@ -8,6 +8,7 @@
> #include <errno.h>
> #include <fcntl.h>
> #include <sys/uio.h>
> +#include <unistd.h>
>
> #include "util.h"
> #include "passt.h"
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-08-20 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 23:15 [PATCH 0/2] Build fixes for musl, glibc < 2.34 Stefano Brivio
2024-08-19 23:15 ` [PATCH 1/2] udp_flow: Add missing unistd.h include for close() Stefano Brivio
2024-08-20 0:47 ` David Gibson [this message]
2024-08-19 23:15 ` [PATCH 2/2] util: Provide own version of close_range(), and no-op fallback Stefano Brivio
2024-08-20 0:48 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsPnnJIo8FhyctN-@zatzit.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=lemmi@nerd2nerd.org \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).