From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=fail reason="key not found in DNS" header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202312 header.b=Oy22YR12; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 85BCF5A004C for ; Tue, 20 Aug 2024 03:31:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1724117470; bh=oeUlanh2TQ7Ms7VVEBZIr9npETYkEi9jntGRXUkeacU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oy22YR12OyGOj74ndLqlyHFBMuNsyJsu2EuvaQ0syTnzue1e0Eyw47o+0bbB/H+ii LhXsz3CjF/PrVn89nel7fq+EC58XbZy2RT5r0PuL0HlqYA1eon0P9J/4kliXnPnQjr e36X+sMsBlSvPYj6i1fRRr2+YNSMrjqHO4CS+Q/qpiHYi29TYNpc1ofcHpFZQ3OclE QTKDdmaS9/DgCCuUEmgMWXL/o/C26Kmio92G2DHmGmqyV9dUQAT4L7mPGGkfLUZYW6 W42CZ5xJ0zx9wkUjNVaE1PYL8TY1BSrNfm0jRmjYyeTSs+WlVTz2ShCXgg7coYc7Q4 i+btiKWwZ5PtQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WnsPB227Wz4wcl; Tue, 20 Aug 2024 11:31:10 +1000 (AEST) Date: Tue, 20 Aug 2024 11:29:29 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 12/22] util: Correct sock_l4() binding for link local addresses Message-ID: References: <20240816054004.1335006-1-david@gibson.dropbear.id.au> <20240816054004.1335006-13-david@gibson.dropbear.id.au> <20240820021459.6a9b8f28@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o0nv2WhlUsxKAIoh" Content-Disposition: inline In-Reply-To: <20240820021459.6a9b8f28@elisabeth> Message-ID-Hash: AM5DPSBIEVTNHJ547P6X5ERCHYQTAMVX X-Message-ID-Hash: AM5DPSBIEVTNHJ547P6X5ERCHYQTAMVX X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --o0nv2WhlUsxKAIoh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 20, 2024 at 02:14:59AM +0200, Stefano Brivio wrote: > On Fri, 16 Aug 2024 15:39:53 +1000 > David Gibson wrote: >=20 > > When binding an IPv6 socket in sock_l4() we need to supply a scope id if > > the address is link-local. We check for this by comparing the given > > address to c->ip6.addr_ll. This is correct only by accident: while > > c->ip6.addr_ll is typically set to the hsot interface's link local > > address, the actually purpose of it is to provide a link local address >=20 > Nits: host, actual Fixed. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --o0nv2WhlUsxKAIoh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbD8XgACgkQzQJF27ox 2Gc7EA//Uz74SLwfuZpXB9QHtnzphM0fpiOHFkFF6LIq/tnHE7y+h/ggTt8HGWRT g1zJ34q7OZ41tne7LXj/QHINY3zASLLQ1zxsTuC4o2eigOx3KEs5xfZYf7Yp9Hsv 9BL+waDtTSy3Ti3LHn6hOFDn2Nc6wFoayufsC/3kpaiMGFQL3Sb160XfCUl7GVNT Cc4dNIalTpei7/TzChD+/iD2YRb395X9f8jaWmggZym6RBBdOUs6Eg7W+tZ9G4zI jybhb9uytrnAebzxjW1hs8IMuYtnNMZ/V2kTs3EX9jUi3zloVkksrZb9ZqiWlDKF ihXIT9ujAsBHoVEBoFWAHzLZTsctpIZTDSI9UsfRpn+Z95xInvXYEb58964nEYuB t+oUJewNL6wmo7m7osWNJYSbPrW66e42BGLDAeyFhYx3Gccr2hUecgd8lXDmf5JY MDGcUo4AyG2Aafn/M3fuVudsx+tx2Gb3u3G1bF4amjb8MYbJD9kG0sYMVO3nzHwn lF1dg38BU+em3c2GSPVK1CVxWtNh8EFc2ZDIkBUaZSOgEDzR7eWdP7BVO9xgRtpj MHfBTFWBxhfpV3vc3Q1LINXLf7WL40PUWMm1c+AO29ErzWekPY4yXRRDGalhyZgQ +yVhizXbzMVHFVgTJxL4GnV/mw64KT4L1Hh8Lju9G5Uw9OxFlZU= =bc9t -----END PGP SIGNATURE----- --o0nv2WhlUsxKAIoh--