On Tue, Aug 20, 2024 at 02:15:03AM +0200, Stefano Brivio wrote:
> On Fri, 16 Aug 2024 15:39:54 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > c->ip6.addr_ll is not like c->ip6.addr.  The latter is an address for the
> > guest, but the former is an address for our use on the tap link.  Rename it
> > accordingly, to 'our_tap_ll'.
> 
> Same as 3/22: could this be "our_ll"? Same here, not a strong
> preference.

Same answer here.  Maybe, but I want to emphasise that it's our
address as used on PIF_TAP.  Obviously we may use host LL addresses if
we contact external hosts on the same link as the host.

> 
> I reviewed only up to 16/22 so far.
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson