public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Maloy <jmaloy@redhat.com>
Cc: passt-dev@passt.top, sbrivio@redhat.com, lvivier@redhat.com,
	dgibson@redhat.com
Subject: Re: [PATCH v2 1/2] tcp: add SO_PEEK_OFF socket option tor TCPv6
Date: Fri, 23 Aug 2024 17:30:25 +1000	[thread overview]
Message-ID: <Zsg6kUGgso6dfCPI@zatzit.fritz.box> (raw)
In-Reply-To: <20240823013637.72719-2-jmaloy@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

On Thu, Aug 22, 2024 at 09:36:36PM -0400, Jon Maloy wrote:
> When we added the SO_PEEK_OFF socket option to TCP we forgot
> to add it even for TCP on IPv6.
> 
> We do that here.
> 
> Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option")
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  net/ipv6/af_inet6.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index 90d2c7e3f5e9..ba69b86f1c7d 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -708,6 +708,7 @@ const struct proto_ops inet6_stream_ops = {
>  	.splice_eof	   = inet_splice_eof,
>  	.sendmsg_locked    = tcp_sendmsg_locked,
>  	.splice_read	   = tcp_splice_read,
> +	.set_peek_off      = sk_set_peek_off,
>  	.read_sock	   = tcp_read_sock,
>  	.read_skb	   = tcp_read_skb,
>  	.peek_len	   = tcp_peek_len,

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-08-23  8:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23  1:36 [PATCH v2 0/2] Adding SO_PEEK_OFF for TCPv6 Jon Maloy
2024-08-23  1:36 ` [PATCH v2 1/2] tcp: add SO_PEEK_OFF socket option tor TCPv6 Jon Maloy
2024-08-23  7:30   ` David Gibson [this message]
2024-08-23  7:43   ` Stefano Brivio
2024-08-23  1:36 ` [PATCH v2 2/2] selftests: add selftest for tcp SO_PEEK_OFF support Jon Maloy
2024-08-23  7:43   ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zsg6kUGgso6dfCPI@zatzit.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=dgibson@redhat.com \
    --cc=jmaloy@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).