From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=CmowGhLk; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 925025A004C for ; Mon, 26 Aug 2024 10:22:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1724660517; bh=5nw+nqUWPHkMPcKyzyCzSKjA+D1aRxifqy/BohmJ4Mw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CmowGhLkJ4L4YdBPXQ7ooxcSzXcJ8nNViLEZuer2VFmOUCCtJFRsvNWMpeXGY5PG1 GTwTfp9Fig/+3AfkRMeykZjHAC2I3C2Y7yMPr4e0V+SyLBU5jEcXnwtFpicObimIj8 V9S/Gt3O7NbJCMpnUWuF/64OgkZijJdRLekUFu7mLa08fByYv1acO8ayA7+W0jhSPU PB9xe7+fkOR73cciVUuw+sBYGWe+vswIlI48HRV49v+zpPaz0vS3SQSbJXwL/dYxiN dbYtyQHZHEmCTybC0ISZlRGL2esA9IcRwWsTotulfOlhycrtjImUZKgZHduR2rKrHU kZssadrO8jX1g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WskDP0hH5z4x5J; Mon, 26 Aug 2024 18:21:57 +1000 (AEST) Date: Mon, 26 Aug 2024 18:20:35 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] Remove incorrect special handling of /usr/libexec Message-ID: References: <20240826063901.590640-1-david@gibson.dropbear.id.au> <20240826095547.43a050fd@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0WG99Jar1X5IGNJx" Content-Disposition: inline In-Reply-To: <20240826095547.43a050fd@elisabeth> Message-ID-Hash: YPQ2S55FDPOVP44E7JF7PFSS4TC76GCR X-Message-ID-Hash: YPQ2S55FDPOVP44E7JF7PFSS4TC76GCR X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --0WG99Jar1X5IGNJx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 26, 2024 at 09:55:47AM +0200, Stefano Brivio wrote: > On Mon, 26 Aug 2024 16:39:01 +1000 > David Gibson wrote: >=20 > > The statement in the comment about /usr/libexec being only for running = on > > other hosts simply isn't true, neither in practice nor according to the > > FHS spec[0]. >=20 > I don't remember where I took that meaning of /usr/libexec from, I > guess it's from some outdated packaging guidelines (Fedora? Kata > Containers?). Sure, it makes sense to fix that. >=20 > > Furthermore this logic didn't even handle it correctly, since > > it would only handle binaries _directly_ in /usr/libexec, not those in > > (explicitly FHS permitted) subdirectories under /usr/libexec. >=20 > So, this change breaks the two cases I needed to cover with this, which > are /usr/libexec/kata-agent in general, and /usr/libexec/qemu-kvm on > RHEL 9. Huh.. why? > What does it fix? I don't have a concrete case, but it would break anything where we're including this support binary, but the "front end" binary looks for it explicitly in /usr/libexec. Which I'd kind of expect to be most support binary cases, since by design /usr/libexec won't generally be in the PATH. >=20 > > [0] https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html > >=20 > > Signed-off-by: David Gibson > > --- > > mbuto | 8 -------- > > 1 file changed, 8 deletions(-) > >=20 > > diff --git a/mbuto b/mbuto > > index a2a8147..5e8ea9c 100755 > > --- a/mbuto > > +++ b/mbuto > > @@ -752,14 +752,6 @@ prog_add() { > > unset IFS > > [ -z "${__bin}" ] && err "Can't source ${1}" > > =20 > > - # Binaries in /usr/libexec are meant to run on other hosts only, so t= hey > > - # can't reside in /usr/libexec on the target image. Move to /usr/bin. > > - if [ "$("${DIRNAME}" "${__bin}")" =3D "/usr/libexec" ]; then > > - __bindir=3D"${wd}/usr/bin" > > - else > > - __bindir=3D"${wd}$("${DIRNAME}" "${__bin}")" > > - fi > > - > > "${MKDIR}" -p "${__bindir}" > > "${CP}" --preserve=3Dall "${__bin}" "${__bindir}" > > =20 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --0WG99Jar1X5IGNJx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbMOsIACgkQzQJF27ox 2GeELg/9EoAhIgWhV+SMYsXiiFSvOHxBFtpSAtKapnmHDQzSEDtqqzESGNwLuDKL MJv+XM+szTNfsbzteuwSThxPpwk7kC+fzVMJT7yj/EuoSwmPjuMMTfthy0lsFGfc 0tMkl9mX3QMyvpKt788Z2+QWTuGnFvbpEgTRYIGYPs9MhN804rNt/4nHISWbxHti Ne21yy6sRlEjnbCpElJoPKPg8XSbCOmUsc1rlb4JqO1HUpNKjWytnhpiotQyxx/W 1BeVuagD0AMwIp7UPcg/kc7fVbzjczhDFVTm4HjwBtuqB+eofa/0zT0L5E4n287w 2bF8ymlOHtuCh9D7EnGoetTylliZqTpB2F/fi/Bge0RSR6F0xOInuijiCibHHUZ1 uGmJUWEsrZvJq7bZCIHOHGv2U6RuIRHs/8VcWXawsXPMXip+xwR8NrbkI9GagrY3 YbiFDo8SgjFJiKiMP4jhXdqs1k9tyOCVE4CI7EJKv1EnmLI9Grw/H5f5N5MZ/QEy FShJJ4f77Y7jDUkeuC2g1+kJ5/RP04PAG2ZZ5pywpo1b26K1Jb902UrxYQPvU1zB sltHQvUL4xEwnqNVZGkh7c5KB08Y0EiaKmAgMTiJLjN/VDz6USAZ1nDaAQbYJu5L t4FL75+kKVCw9WvjwMnZUA2gYtoWRA82K4oYGxObFByxGLwj0FA= =p+yG -----END PGP SIGNATURE----- --0WG99Jar1X5IGNJx--