From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=r1jchtTN; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 91D865A004C for ; Mon, 26 Aug 2024 10:22:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1724660517; bh=Q8YKc2F9Y1c2bY9BF5Wk3HJTYTN92EhER2+wVQG1PGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r1jchtTN+WrnbqvTH2vW4yuvfAe/si3vRtnlnhoPWC0qYldLCgI6SukGjrCaZsv3w k9Kr22FL4iJYx8kBDcife3r3dtfx46Q59/+FZxc4j3rlkctO90PiBi4OdKtlncxOdf n9QP2q2Tu6imMKfQiV86w6nIVkRyfrTbf6PQSKSTzccKRDQLkieaZh+Y0T3sW/aIOF fyCf11m6LSn6VW+eIjjGBX0EMIMYvu4sDQ7dhv3IAkO7XPjucEx+yQbxqynctzyTYo COrdRE3kBIrFgw4QlwM146gIFezMPLyisYggpAtnas67a85nsN9KhVPWIEr9+jXxCt k0SOieodm0hMQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WskDP0lzjz4x3d; Mon, 26 Aug 2024 18:21:57 +1000 (AEST) Date: Mon, 26 Aug 2024 18:21:53 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 3/4] test/passt.mbuto: Install sshd-session OpenSSH's split process Message-ID: References: <20240819231434.1481576-1-sbrivio@redhat.com> <20240819231434.1481576-4-sbrivio@redhat.com> <20240826095550.4ece4c8b@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MCVP8Ud62LgVYsdg" Content-Disposition: inline In-Reply-To: <20240826095550.4ece4c8b@elisabeth> Message-ID-Hash: DPMKY65YBA6AIQXCXFO2XRGV5T5WO66R X-Message-ID-Hash: DPMKY65YBA6AIQXCXFO2XRGV5T5WO66R X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --MCVP8Ud62LgVYsdg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 26, 2024 at 09:55:50AM +0200, Stefano Brivio wrote: > On Mon, 26 Aug 2024 16:41:23 +1000 > David Gibson wrote: >=20 > > On Tue, Aug 20, 2024 at 01:14:33AM +0200, Stefano Brivio wrote: > > > OpenSSH now ships a per-session binary, sshd-session, with sshd > > > acting as mere listener. It's typically not found in $PATH, so specify > > > the whole path at which it's commonly installed in $PROGS. > > >=20 > > > Link: https://www.openssh.com/releasenotes.html#9.8p1 > > > Signed-off-by: Stefano Brivio =20 > >=20 > > Oops. I reviewed by sight, but didn't test. > >=20 > > This breaks completely if you still have an older ssh without > > sshd-session. That includes running on Fedora 40 as of today. >=20 > Oops, I forgot to check this on Fedora 40, and I see it's actually at > /usr/libexec/openssh/sshd-session on Fedora Rawhide. Yeah, I thought it'd probably end up in libexec on Red Hat-ish distros. > > I'm not immediately sure how to fix this within mbuto's constraints. >=20 > Well, the profile files are shell scripts as well, so we can just look > for sshd-session in both places, and add it to $PROGS only if we find > it. I can test and send a patch in a bit. >=20 > > > --- > > > test/passt.mbuto | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/test/passt.mbuto b/test/passt.mbuto > > > index 4abaafc..61865e8 100755 > > > --- a/test/passt.mbuto > > > +++ b/test/passt.mbuto > > > @@ -13,7 +13,8 @@ > > > PROGS=3D"${PROGS:-ash,dash,bash ip mount ls insmod mkdir ln cat chmo= d lsmod > > > modprobe find grep mknod mv rm umount jq iperf3 dhclient host= name > > > sed tr chown sipcalc cut socat dd strace ping tail killall sl= eep sysctl > > > - nproc tcp_rr tcp_crr udp_rr which tee seq bc sshd ssh-keygen = cmp}" > > > + nproc tcp_rr tcp_crr udp_rr which tee seq bc sshd ssh-keygen = cmp > > > + /usr/lib/openssh/sshd-session}" > > > =20 > > > KMODS=3D"${KMODS:- virtio_net virtio_pci vmw_vsock_virtio_transport}" > > > =20 > >=20 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --MCVP8Ud62LgVYsdg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbMOyAACgkQzQJF27ox 2GdDmBAAmV+Iii4pRE9ihZQMQ7/0MY/niznspVt4DNd/ho+OsVZZDih7R5eCaM7G kHSQHz3lQ3KIolzOL9P6ypk8uKAVeyZFBsnYGqyX/HsWoe+2NlPJa47awqKdAiq8 hYYf87Tmrz6DkMG4JbZ9f/DMV+YNMDXKZGPY2CyQY3eGkRviyPeRIZG0jq9xt9uo 5O/9bPa0+m1iWzL2HsKxktmhV2r7qi7MILY21VHnUwcpqXNijpDE0IwsuLmHdB98 2Imb2q62Ui/ja57wEz28QP4csBrkyYkOKb/9SE3r5uyE6CRrO28PR2Pf7n2RTsed ng53+kPJKSErTYBSKKgvkbiXwbo0ijOlHZYdzQ7h35W5FqGCdYGHX41ulLeyN6/Y KF/aLIU3jnRkME6xJa32N/fjnZJBTzorYPiuJmwfAPz6RYLbOGmNuU7M2b44pGtG 8p3hkuD0MeREytAHagNmFFKaGvc4p1Azj4sKsnCOrjk/w1+Uc6ylAU2e2zjftfXi zZOmicMefBGEhTOt/ONviyxhgEezvsvpIMhJvssFp0i8Bul7v9ucQwg9lu+47tL0 jNYlXEjr48eAButxwJKrJdctzHNfsblESWJqoQcuHKc2GpD9DHBBbVVm7XkEUDc3 LUKqWxjUlAAVbiVsA7tOZuTu+2ixO9bWMK7y+MOf9zum5LU2TPA= =lcDs -----END PGP SIGNATURE----- --MCVP8Ud62LgVYsdg--