From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=OpTAUbzc; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 414F45A004C for ; Mon, 26 Aug 2024 07:28:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1724650082; bh=Z8zhdcAX1E3S/lFAe1DoO4ioAw1qlugdJyzHxEB8bSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OpTAUbzcPMsVOxhTjirGS2gXsPlhc+tHR7geSOFSm8CgFf248x2gibb5NP0vfXoLn +UBtnBI+gs2qm4UUfDHK+6GlhmHgBGbpWrwbYXP1Zeg9bPhfpTEg4jydntUZZ21+VG ABMZCns/SZ1IlnRnWUrmUXx5oiYCU8QA1ZwUlRfPp/zfaBVwfExRG8t9GEpoa3TXdv cNT5SuAqhULg0zE4WZhVJ6Iv+yXLKiMOQjVDH+vn1ikHg1anlhXGBzr7b1CPCsTA4P O1ALypb8c/DglNqQq3M5+TNj7oXNnOaGldJLa6OB9B2lAcIfNv20ht83OPLo4pHwyB IxNKlEk38iYEQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WsfMk0xNnz4x81; Mon, 26 Aug 2024 15:28:02 +1000 (AEST) Date: Mon, 26 Aug 2024 15:27:59 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 3/4] vhost-user: introduce vhost-user API Message-ID: References: <20240815155024.827956-1-lvivier@redhat.com> <20240815155024.827956-4-lvivier@redhat.com> <20240823001422.6c441841@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EvoiBUn0l8u29kKC" Content-Disposition: inline In-Reply-To: <20240823001422.6c441841@elisabeth> Message-ID-Hash: I7B74T23GBDPQH7M5D7DRBPGBW7PPKY6 X-Message-ID-Hash: I7B74T23GBDPQH7M5D7DRBPGBW7PPKY6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --EvoiBUn0l8u29kKC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 23, 2024 at 12:14:22AM +0200, Stefano Brivio wrote: > On Thu, 15 Aug 2024 17:50:22 +0200 > Laurent Vivier wrote: [snip] > > + if (sz_payload) { > > + do { > > + ret =3D recv(conn_fd, &vmsg->payload, sz_payload, 0); > > + } while (ret < 0 && (errno =3D=3D EINTR || errno =3D=3D EAGAIN)); >=20 > No need for curly brackets, it's a one-line statement. Unlike if, while or for, I'm pretty sure the braces are mandatory for do {} while. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --EvoiBUn0l8u29kKC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbMEl4ACgkQzQJF27ox 2GfGlw//T+JuaTkRhwpeT/SYUn0WIKlz2iXRrpQUWwKMzSMVLZek9HFolPecYbkg ENs9+FP4kx1pVNaNmynzRgoEptiGiGUSPEBufmahN0QsA8MnH2kQhBaavmwHbas9 TtDdtWDk28eWTAkf1OdRnV+DxEUXZM+W9gdm03La7DAnyQlh5IIpSB4Nx0v4MJsf GE88yDG6RgsTuUTYQIthSSAGBs+OKfi6ULKHel6DMCPPJ0W0KB4RsRFuvEqcQcTj BXvhs5Au87wwAibbEeDwD32Pj26u9fVXSPHqXu0uo3f1aJA6wxXT3arLgsl7quMW MXtsj+AfIsPw85tutnd7au0JgNvKL+NsggXJ/sleoMAvqHwxQhXUi4z9uOAXeLst 7y1u/Cl/zWe0FPgOAcUkWCxix4mqxTEVcizfRn/xcCIEoRo/ohJe6gGOr5fezZ/T Ars9k+2ngJ6sK7R2ClRbB4Je3v9EOMsu+2jBbCBGno8xEpTN1PTq1vKncrihH1I3 Ljyz5apkLN8K3+UNk62YGc9RAe7kiskETaWkvIwKum4t83jbQ622KML/RvXZUVEl N9mfzf4JRR1NomS7Z2TAyzogZFnZBYbNdZlY0yxNfyGB3HG+qCAdXhMfqYQScz9K DhjXU9fDKQH3GQM1DBcEU5G7i8QcxX/ocGwJRBycX7JuqnB8PpI= =twPI -----END PGP SIGNATURE----- --EvoiBUn0l8u29kKC--