From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=sZYhbpU3; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id AE7505A004C for ; Mon, 26 Aug 2024 08:42:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1724654550; bh=UmCHzN5auu52Wol/mx/8mfPongIz74ehp054jsd4puU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sZYhbpU3daV5Yw2TbwTFRIvhoY0Pl5HQmEIHJSHTVu09pX+PbM/edv82pFWlm9Xkn f2nNkaIbiC/MBXsQhQa5irrrIuFYjy06S4KpCEZpYB/NDumj8rWoKo3kgAb9flLevN 2ZpsG1ln2Ozl+QCqNsM5C4V023kYFBijUejF5zTAOq6RVB/aH6DgwieBSS2b9ya5eD 6vB16Ctwsib8/sCo5Jx8R6fMhve7VyPXHhedJZgOcejqCDvBsW2B7dpx3CCIlM7pRK DqqYDbUFrCqCu4cPK6dUyjPv3EUCAeM/z0Zd8j2TRdRGgr7JHhFRUfiPRZgk+C4e2r wJbZaenVB/WYg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Wsh1f3Tpkz4x3d; Mon, 26 Aug 2024 16:42:30 +1000 (AEST) Date: Mon, 26 Aug 2024 16:41:23 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 3/4] test/passt.mbuto: Install sshd-session OpenSSH's split process Message-ID: References: <20240819231434.1481576-1-sbrivio@redhat.com> <20240819231434.1481576-4-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FicyWhaT4hOgEE2y" Content-Disposition: inline In-Reply-To: <20240819231434.1481576-4-sbrivio@redhat.com> Message-ID-Hash: RBT7OD6EV23GCF3EZYJTXXZ6MTFHOQMP X-Message-ID-Hash: RBT7OD6EV23GCF3EZYJTXXZ6MTFHOQMP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --FicyWhaT4hOgEE2y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 20, 2024 at 01:14:33AM +0200, Stefano Brivio wrote: > OpenSSH now ships a per-session binary, sshd-session, with sshd > acting as mere listener. It's typically not found in $PATH, so specify > the whole path at which it's commonly installed in $PROGS. >=20 > Link: https://www.openssh.com/releasenotes.html#9.8p1 > Signed-off-by: Stefano Brivio Oops. I reviewed by sight, but didn't test. This breaks completely if you still have an older ssh without sshd-session. That includes running on Fedora 40 as of today. I'm not immediately sure how to fix this within mbuto's constraints. > --- > test/passt.mbuto | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/test/passt.mbuto b/test/passt.mbuto > index 4abaafc..61865e8 100755 > --- a/test/passt.mbuto > +++ b/test/passt.mbuto > @@ -13,7 +13,8 @@ > PROGS=3D"${PROGS:-ash,dash,bash ip mount ls insmod mkdir ln cat chmod ls= mod > modprobe find grep mknod mv rm umount jq iperf3 dhclient hostname > sed tr chown sipcalc cut socat dd strace ping tail killall sleep = sysctl > - nproc tcp_rr tcp_crr udp_rr which tee seq bc sshd ssh-keygen cmp}" > + nproc tcp_rr tcp_crr udp_rr which tee seq bc sshd ssh-keygen cmp > + /usr/lib/openssh/sshd-session}" > =20 > KMODS=3D"${KMODS:- virtio_net virtio_pci vmw_vsock_virtio_transport}" > =20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --FicyWhaT4hOgEE2y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbMI4wACgkQzQJF27ox 2Gf00Q//bDx7QYUQDpRc9gg8giWWd1vAtN0E+48hBBWj4+2hwcPU7CngMdhn0u5M tjtTceQAF8TeehDzgtZikgYFfOU7EjoFDDfmoJ8TG+6bDmQ5bf0VJPZe3B+bj8YX Taat/hR57ru66oyOJ/w6ndZAXATF+DWdO9yxbdKxiuNGIAYewJwI/IqxgsOjJe+6 vX0sT20of0w7My4T4oxUioojOIa3SKN/ejZTPa8s7rnoJlLwG+b3SNMq7/fD7Esa NGggXqZMoy5Kb8irEKxVRsXTSf2K9iXxPH7FJax6sHQWZW/+9fQ1idgUOS56BqGz 2PfL7kXU9Y55xDuw7hVq0G/xETboQewgQw/8841fUmoO2z3SFRanUSWbXcCKWxNe ZHKarY7UFqFh2jyMVwqjxnJ6OTJQyOzez1aQ0ZVL5obZ7Yy8DVyXzspbPoUajmL7 vbrw0cIQ1tqOzi11hKsh6uJdMDW+ybIPHVyfRoQYRxdsYhzSmS8RJGyvXOb8EsCz SqVbsGqkIktXdv9nvT10pypJn+8g2It/KVvaze1BQUXejOzmXrrHKkpsCtNAiSpM 3TtmOD13vuOALXBR5XmxAH0BgZ6rN6LVAT96Ir1NV9n+rMCuBxD4BHivpyZB3LZo uaL3QUwW8QcS+Yg9LNxNY7KicXpUWVmXILiiF6IyIAO84RbbWUk= =CxqR -----END PGP SIGNATURE----- --FicyWhaT4hOgEE2y--