From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=a8UvsNOA; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 455095A004E for ; Thu, 29 Aug 2024 08:53:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1724914424; bh=yrA4KFzcAjbiDNrgP6OWNkZ8J2qb33ZsK/vfxZzXcMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a8UvsNOAk3SRf3ROr5w3Bx+CYbLEygexNbxhggX7eoJTDaA6RsMoCimmW2kntdQvU cQDGxrtVhayWD40EmfaLEei5yiAOBbA+pNk9n6TlPjsH/6ln9SVTDhBW/+PBYAQY9E MmO541bFyBxMVtEkg7Ti+Zlsj0SmT6j3wr3SWhe0cEOSWtgE2VzC3BoAL3M2+DsQgK 6yEMv/CRHbvj2G2+jisv1MuuD6wHdyuSoBpoiuNL4bR8qMLG0OCOnxDc16lKo2nByp y2GiaCe0imCzdiL0Mj9VjjPuNja8t0ByIhCBDd3Lec4w6e0NGuGog92Kjc5F7lsQfW jycSLh4EQHkjg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WvX7D5yVFz4x2d; Thu, 29 Aug 2024 16:53:44 +1000 (AEST) Date: Thu, 29 Aug 2024 16:53:40 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v2 1/3] conf, fwd: Make ephemeral port logic more flexible Message-ID: References: <20240829013242.3396770-1-david@gibson.dropbear.id.au> <20240829013242.3396770-2-david@gibson.dropbear.id.au> <20240829065905.35be74c8@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MgzX2OH23c+A9tcU" Content-Disposition: inline In-Reply-To: <20240829065905.35be74c8@elisabeth> Message-ID-Hash: OYMTR2YY6JSZD2OPLA4WJHACJXZ37RWS X-Message-ID-Hash: OYMTR2YY6JSZD2OPLA4WJHACJXZ37RWS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --MgzX2OH23c+A9tcU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 29, 2024 at 06:59:05AM +0200, Stefano Brivio wrote: > Nit: >=20 > On Thu, 29 Aug 2024 11:32:40 +1000 > David Gibson wrote: >=20 > > +/* Empheral port range: values from RFC 6335 */ > > +static const uint16_t fwd_ephemeral_min =3D (1 << 15) + (1 << 14); > > +static const uint16_t fwd_ephemeral_max =3D NUM_PORTS - 1; >=20 > Maybe you could use in_port_t instead, just for consistency with > (almost) everything else, no advantages otherwise. Duh, of course. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --MgzX2OH23c+A9tcU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbQGvMACgkQzQJF27ox 2GclHw//eA3Xor80M5VVimweguxxK+KZJdcPjdJMChKSrdj7yTLi6RQ3hWnRU812 w89roblbNnA7owUejojRbw8NLbCeVIeofszhhQE8gOb5LaMb5ZNUKTR/WhMOjLmH VSQSwxG6k9yoOyd6mQs+C2XyDAIsDlk2xaiJ0aET+ai8HOhv6kbw9be5q+cziweQ 59rslBmSr1md4JVj0LG77BOiRThZHo3CZNNnoghSK8Ew1m3A/hyYNnNGnl9vQh/R mxJ9EhFBP+CcWq6RPxDW8T3UbXFEp83rnKw2dsDO5oEys/Nwv58tH/fb/Yw0CioA lWULxsVCWjtp3wCMUQAvDY5o2ErzoS50XsWHtGAYbNOZ8BPz2V2vEKjYhrGdAU/4 GCgoU600J0jXg3lJjXy+Up+ty5sHiWSEDBl8UpYvZ2/nQy5CaUP4UVHL88ewBcEL XlzhpwOWbgj8sUydr7KBRcpeGVr5ZHc7RqQGBf9Qnrgex/zbgowH69HfoRbLtrb9 GP/h11oKjTA3sCLeNodFJoeHUZXU2uIYk+03cPZze3GyQbntMC86uufGH8xkfDeB 0gKBrFqtAj+ZGETgoa/vNX24mbNfSuOHjUMCRhGdy6lruul6qbUL3e/WczoTuVfe L7j2V2LQO9gXq1DUch9Wys6ug6HrRBUtNvx9BULYBGZC8cFSy+c= =ESmb -----END PGP SIGNATURE----- --MgzX2OH23c+A9tcU--