From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=DREbmEYE; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 40DC55A004C for ; Wed, 18 Sep 2024 01:41:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1726616503; bh=bb1bNMHKsUR46TyI1lTOIRJMJxsrxf9WC5qQxT1JZfI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DREbmEYEb6/fEBJZ1ljaUsKFo0tnrnwka5QM4ytYfZyE+ddFyqebY15c4JB/1KOJb I2FONumrx8HXiszoFzcMp1XEjcPeYu6XPmGYTmekQKmGvFXX2+Dilr8NyFLQFdYxYg bVxjXSjWNygJRY2TbwmJ9R050T3uUWUB+9a7IpqyOGDAxRkNmBWYHJqyVJ0I/zg+Ns CnbES3KiEMO1Ak/4F7oN8jZoBoieDaQdPmmio/DEMjCQ7Go03yQDsYDPN8rnhu1g7v Ds7R91NH+6xVCopyDvpc8Yf8buoAJHElCmm40OhK105Sl4HIVAczGCb9yoenevXd2/ 4l5jo4VJelEuA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4X7dbW5sCbz4xbw; Wed, 18 Sep 2024 09:41:43 +1000 (AEST) Date: Wed, 18 Sep 2024 09:41:37 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v2 1/2] udp: Allow checksum to be disabled Message-ID: References: <20240917073058.3666887-1-lvivier@redhat.com> <20240917073058.3666887-2-lvivier@redhat.com> <20240918010650.417b2dbe@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M7c0gWu+hqSeX4H2" Content-Disposition: inline In-Reply-To: <20240918010650.417b2dbe@elisabeth> Message-ID-Hash: H37GDGTFG22HSKCZ2YJ37FQH265KBEGD X-Message-ID-Hash: H37GDGTFG22HSKCZ2YJ37FQH265KBEGD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --M7c0gWu+hqSeX4H2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 18, 2024 at 01:07:00AM +0200, Stefano Brivio wrote: > Nits only: >=20 > On Tue, 17 Sep 2024 09:30:57 +0200 > Laurent Vivier wrote: >=20 > > We can need not to set the UDP checksum. Add a parameter to > > udp_update_hdr4() and udp_update_hdr6() to disable it. > >=20 > > Signed-off-by: Laurent Vivier > > --- > >=20 > > Notes: > > v2: s/UPD/UDP/ > >=20 > > udp.c | 41 +++++++++++++++++++++++++++++++---------- > > 1 file changed, 31 insertions(+), 10 deletions(-) > >=20 > > diff --git a/udp.c b/udp.c > > index 2ba00c9c20a8..95151efb9c46 100644 > > --- a/udp.c > > +++ b/udp.c > > @@ -298,11 +298,13 @@ static void udp_splice_send(const struct ctx *c, = size_t start, size_t n, > > * @bp: Pointer to udp_payload_t to update > > * @toside: Flowside for destination side > > * @dlen: Length of UDP payload > > + * @no_udp_csum: Do not set UDP checksum >=20 > The description of all the other arguments are aligned, with tabs. You > could just add one tab to all the others and have them aligned. >=20 > Actually, this could simply be 'no_csum', it's obviously UDP. Same for > no_tcp_csum in 2/2. I had been going to suggest the same thing, but then I realised the current name does disambiguate it from the IPv4 header checksum. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --M7c0gWu+hqSeX4H2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbqE6sACgkQzQJF27ox 2Gf4JA//QHYd7xJkdjlukMr1hDxZDnol6N2O6eO4ohhFrCHfzRydkHCqMLD/2QmT 25guH897rSjdJvU7/gIiTstzlVleHapTs3504lNKXlO7zMrnyuuJwjGzT2dW5eYI /LrS7Hv8QAkEdGXO7IlL30yqIpNGD1cdqI08SgQ5wpHb9cxVpOyfI+z0Vo+S+l6z iTuoeJalBpNvEEIEHvefEuSyaxvncyz4oesYz5QRh2MudchphtKgYMD+SDYeLp2M iw+Hbr7XynueczIZ7NngqCDDFsQa4gGzVztuPBCSnH0WDd+mcku+zCAO2wq6xUX9 hSgFM2H88X3ksFhdKQPIGg7iZd1ytTJf5JazFW6X8HcrC84A2ItJcCeKhywI/2rt 5cMteDmeUHqCuuuhtytvpqtGs55X0iDVH4qvXGw39tjilgFGxFg+ZbwrUWVvBBNB cn4e219+a8rS7sJs7Ptdh984K/VadUV5sKVqtNvz817v+vs5o1WWUV52gPsh7m+U PgRMvzCRK5mCPXcvDi3PQ2qAxim9rXxlyxfeZYnnPxC1xTXEZvQLUJ5sOJinqJGJ FtJGEJSwp9sArFb67fyEjzzkaFkjhSIT1HMy2VPR2T9YtbykGbFU562fUgrLhzqo 0yu7XyQcf0wEa7k29Z/2Uu2M1yduCyuI0WTZORlKBoxHEQMwgCU= =ZVAr -----END PGP SIGNATURE----- --M7c0gWu+hqSeX4H2--