From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Maloy <jmaloy@redhat.com>
Cc: passt-dev@passt.top, sbrivio@redhat.com, lvivier@redhat.com,
dgibson@redhat.com
Subject: Re: [PATCH v3 2/2] tcp: unify l2 TCPv4 and TCPv6 queues and structures
Date: Fri, 20 Sep 2024 14:52:28 +1000 [thread overview]
Message-ID: <Zuz_jOwfCAsQ5-UH@zatzit.fritz.box> (raw)
In-Reply-To: <20240919184409.3511070-3-jmaloy@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On Thu, Sep 19, 2024 at 02:44:09PM -0400, Jon Maloy wrote:
> Following the preparations in the previous commit, we can now remove
> the payload and flag queues dedicated for TCPv6 and TCPv4 and move all
> traffic into common queues handling both protocol types.
>
> Apart from reducing code and memory footprint, this change reduces
> a potential risk for TCPv4 traffic starving out TCPv6 traffic.
> Since we always flush out the TCPv4 frame queue before the TCPv6 queue,
> the latter will never be handled if the former fails to send all its
> frames.
>
> Tests with iperf3 shows no measurable change in performance after this
> change.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-09-20 4:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 18:44 [PATCH v3 0/2] tcp: unify IPv4 and IPv6 tap queues Jon Maloy
2024-09-19 18:44 ` [PATCH v3 1/2] tcp: set ip and eth headers in l2 tap queues on the fly Jon Maloy
2024-09-20 4:20 ` David Gibson
2024-09-19 18:44 ` [PATCH v3 2/2] tcp: unify l2 TCPv4 and TCPv6 queues and structures Jon Maloy
2024-09-20 4:52 ` David Gibson [this message]
2024-09-24 20:30 ` [PATCH v3 0/2] tcp: unify IPv4 and IPv6 tap queues Stefano Brivio
2024-09-25 0:00 ` Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zuz_jOwfCAsQ5-UH@zatzit.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=jmaloy@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).