From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=hOpVrKdj; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 69A4D5A004E for ; Fri, 20 Sep 2024 06:52:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1726807958; bh=f18k7XY/iPYzrtx/YxNJYVXt78ipDl9oNm/8VV4Yajk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hOpVrKdjWXqglnl/WcElc0Dv8UoBFUPZL/7P3k/eBdeZETMDJWJXTTSotRakWSz0b YFJHJFCUTMbRG2S6hUaXB9PWQAtiKz+66ZRPHhRZpCwRlrdw59hpLaA/wUMYh/ecpw YFoDph13HsuIGUn+75vp8vhEt7Yo9263M4+lY7coHfjAK3PI4lRtPWbxs3B7y+vOPT O+ppi0IghX8SOFCLq40v8mjoEOlMxIGjTrDnCtP5LMNfQrYUyivrghPq+fQmOxjEYJ ZcASIBP/TzUek93n/6NuVL7SGyIwAQMX8PPzv7s42h9hJjX+Im8z/eojlsWcHpJ2V/ RWcXJBcTvxBGQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4X90PL1NLgz4x9D; Fri, 20 Sep 2024 14:52:38 +1000 (AEST) Date: Fri, 20 Sep 2024 14:52:28 +1000 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v3 2/2] tcp: unify l2 TCPv4 and TCPv6 queues and structures Message-ID: References: <20240919184409.3511070-1-jmaloy@redhat.com> <20240919184409.3511070-3-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dteRpI9bLVkc9X7m" Content-Disposition: inline In-Reply-To: <20240919184409.3511070-3-jmaloy@redhat.com> Message-ID-Hash: GK2265C343HUMVADLRG2CFEQVV644RDW X-Message-ID-Hash: GK2265C343HUMVADLRG2CFEQVV644RDW X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, lvivier@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --dteRpI9bLVkc9X7m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 19, 2024 at 02:44:09PM -0400, Jon Maloy wrote: > Following the preparations in the previous commit, we can now remove > the payload and flag queues dedicated for TCPv6 and TCPv4 and move all > traffic into common queues handling both protocol types. >=20 > Apart from reducing code and memory footprint, this change reduces > a potential risk for TCPv4 traffic starving out TCPv6 traffic. > Since we always flush out the TCPv4 frame queue before the TCPv6 queue, > the latter will never be handled if the former fails to send all its > frames. >=20 > Tests with iperf3 shows no measurable change in performance after this > change. >=20 > Signed-off-by: Jon Maloy Reviewed-by: David Gibson --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --dteRpI9bLVkc9X7m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmbs/4sACgkQzQJF27ox 2GcyGg/9HZnXq4ERzRlLApVqxtQa/9lV50Ot4SMPjQlsogLfquG14tO04h4kd4u4 e/t9h8N3Q6r2q5CSFyLVbHnwpGob+GRQYQQkUn0AobJawVto9Ow3sP+x+zRhuqFt nDOwyt+N++Sv7zmrgOptcBvv1SnLdvt2IoyeRNva1desnc9pPWbM166hrl0zgqoX nIKHomnI+tKpJi2Yx/xiPhKD1Xcuo5S2CsX40I0E6crh7CNDKfvDemPJVQAXPoE8 JWuHNIsOZG4btPOAEYKql3IUZNvL0+eNDA80c7I6YDi4UReUPQsrBJr2+zTSAhI9 EWzyXj0x7KD+nytnMkyO0dvf74FVOlp0MPZQ1H4oKaRHHTNfsDUhgmdyzD6cAjMj iCOrcUxfJycl4RBo2UwQr8ayxN/PVNk/W7DXepSEjlZIsCK+WCuW1PJev1N8Um9G iU/Ig7qRdPDi4FfnLy/v6VXJGN0NBJ+vQMY+GyTJduhvuBJpZ5vhCybByOUpYBkl IW86Eae52VssxsDff8hMKYN3J6kfUgNJ3sYxuclYyvMfoBm4cORdwXhzM0M7zXmq XCIgrjW8jM5uipJ0wKLZIAobjziU06WsC9l2hDOjOQVhhUBXbUlHR5PNmqvkbEvU nQo/S+gY2KL+rc5/8K0Gm5BXi03jvNgp1idWFAze50rqoQ0ueBE= =cMPJ -----END PGP SIGNATURE----- --dteRpI9bLVkc9X7m--