Re: [PATCH v2 2/4] mbuto: Use realpath to copy ld

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

On Wed, Sep 18, 2024 at 12:12:57PM +0200, Lukasz Gut wrote:
> Place ld in exact physical location as on host, not being confused by
> links. Use realpath, that was already on the list of default PROGS.

It's not clear to me why this change is necessary.

> 
> Signed-off-by: Lukasz Gut <lgut@lgut.eu>
> ---
>  mbuto | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/mbuto b/mbuto
> index 1c3b347..1f92bd9 100755
> --- a/mbuto
> +++ b/mbuto
> @@ -644,12 +644,13 @@ libs_path_add() {
>  # libs_copy_ld_so() - Copy run-time linker program, mimic location from host
>  # $1:	Path to run-time linker
>  libs_copy_ld_so() {
> -	[ -f "${wd}/${1}" ] && return
> +	__srcfile="$("${REALPATH}" "${1}")"
> +	__destfile="${wd}""${__srcfile}"
> +	[ -f "${__destfile}" ] && return
>  
> -	__destdir="$("${DIRNAME}" "${wd}/${1}")"
> +	__destdir="$("${DIRNAME}" "${__destfile}")"
>  	"${MKDIR}" -p "${__destdir}"
> -
> -	"${CP}" --parents --preserve=all "${1}" "${wd}"
> +	"${CP}" --parents --preserve=all "${__srcfile}" "${wd}"
>  }
>  
>  # libs_dlopen_copy() - Recursively copy matching libraries from LIBS_DLOPEN

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]