Re: [PATCH] test/lib/term: Always use printf for messages with escape sequences

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

On Tue, Oct 08, 2024 at 10:44:47PM +0200, Stefano Brivio wrote:
> ...instead of echo: otherwise, bash won't handle escape sequences we
> use to colour messages (and 'echo -e' is not specified by POSIX).
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  test/lib/term | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/lib/term b/test/lib/term
> index 0fa0936..fcbed16 100755
> --- a/test/lib/term
> +++ b/test/lib/term
> @@ -31,8 +31,8 @@ PR_DELAY_INIT=100 # ms
>  # $@:	Message to print
>  info() {
>  	tmux select-pane -t ${PANE_INFO}
> -	echo "${@}" >> $STATEBASE/log_pipe
> -	echo "${@}" >> "${LOGFILE}"
> +	printf "${@}\n" >> $STATEBASE/log_pipe
> +	printf "${@}\n" >> "${LOGFILE}"
>  }
>  
>  # info_n() - Highlight, print message to pane and to log file without newline
> @@ -47,13 +47,13 @@ info_n() {
>  # $@:	Message to print
>  info_nolog() {
>  	tmux select-pane -t ${PANE_INFO}
> -	echo "${@}" >> $STATEBASE/log_pipe
> +	printf "${@}\n" >> $STATEBASE/log_pipe
>  }
>  
>  # info_nolog() - Print message to log file
>  # $@:	Message to print
>  log() {
> -	echo "${@}" >> "${LOGFILE}"
> +	printf "${@}\n" >> "${LOGFILE}"
>  }
>  
>  # info_nolog_n() - Send message to pane without highlighting it, without newline

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]