From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202408 header.b=Z3V26d+8; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id C543C5A004F for ; Thu, 10 Oct 2024 03:31:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202408; t=1728523891; bh=3qb5D7Njlf+r9OvAeR/XVR0yiXbo1lK4mJM6cTWsO+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z3V26d+8YM7ayG3C41r/zK0BnyFF/tCWH9T0pJ+i4xpHq5AA3yCVorI4d0p63pSCx hhv78MlirR6lC4trLi/m2379KwTJh2zGkZX7iD9E395s19TmOokEjZWzedrYaF58FA gAR5fuQAphvEGSKj9cqNfqoAYlwzEgn+tqyQrUu0U1GAorLqL12l6Aht6YN5J6p8gU 019OYvIF4yyUzo1ONyZlf+mfZ7hKbd+SAv5RTyv8oMOde1o78P6LfUWQdVWPeunlTl S/9HfxVBu0eEu/LLiHcd2SIV+SfqfyAKGAZzxiUs6Wag9h08yUpN/YNBgNrq2V7xgr KeC00XTLxEk+w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4XPC034ggvz4x8g; Thu, 10 Oct 2024 12:31:31 +1100 (AEDT) Date: Thu, 10 Oct 2024 12:23:56 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] test/lib/term: Always use printf for messages with escape sequences Message-ID: References: <20241008204447.2793617-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j9HmnOu4/O3b3U8i" Content-Disposition: inline In-Reply-To: <20241008204447.2793617-1-sbrivio@redhat.com> Message-ID-Hash: LJEEMZUQSZ65YMV5MWOOH2OQWDECVF6L X-Message-ID-Hash: LJEEMZUQSZ65YMV5MWOOH2OQWDECVF6L X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --j9HmnOu4/O3b3U8i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 08, 2024 at 10:44:47PM +0200, Stefano Brivio wrote: > ...instead of echo: otherwise, bash won't handle escape sequences we > use to colour messages (and 'echo -e' is not specified by POSIX). >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > test/lib/term | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/test/lib/term b/test/lib/term > index 0fa0936..fcbed16 100755 > --- a/test/lib/term > +++ b/test/lib/term > @@ -31,8 +31,8 @@ PR_DELAY_INIT=3D100 # ms > # $@: Message to print > info() { > tmux select-pane -t ${PANE_INFO} > - echo "${@}" >> $STATEBASE/log_pipe > - echo "${@}" >> "${LOGFILE}" > + printf "${@}\n" >> $STATEBASE/log_pipe > + printf "${@}\n" >> "${LOGFILE}" > } > =20 > # info_n() - Highlight, print message to pane and to log file without ne= wline > @@ -47,13 +47,13 @@ info_n() { > # $@: Message to print > info_nolog() { > tmux select-pane -t ${PANE_INFO} > - echo "${@}" >> $STATEBASE/log_pipe > + printf "${@}\n" >> $STATEBASE/log_pipe > } > =20 > # info_nolog() - Print message to log file > # $@: Message to print > log() { > - echo "${@}" >> "${LOGFILE}" > + printf "${@}\n" >> "${LOGFILE}" > } > =20 > # info_nolog_n() - Send message to pane without highlighting it, without= newline --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --j9HmnOu4/O3b3U8i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmcHLKsACgkQzQJF27ox 2GfLJw/+N+hQZQprOeb3H2HzTDQ/QTiRER818GbroWDlc00s3+txJYcnM1WC/8XW EXvVNCAo3oAxE27NGmJwfIqVW6vm3suxh+UdOzklg+x++vOy7ry//NhStdjpvixL UopcjwVmhlvWm6GsceMUnG7iIl3wQU+/wnbBsgbV8IvmxhWwLx55keCz4oTULr/6 IqNhnVlc4Uv9thkXK+ROQWV0/SlyvY8RT5qPcCMdRsvySmReevYSDdWNWB9RFM7j AhlBf9LZwsNjtvSInq+ac9pn/ubw7izfo3iPvraO3031V07diBl4xUqRzRisaug0 ALqBGRBLNZyXSU6TMddz0YCdUeVynnQm77dYZnYeuLoqL4qNvYfSmcC6/OtoBMzy 6Kz4PuhsHGYoV6GL720oH5grT+yE8o6E8/+C3sG0TxUuiF6rxdfQQ2OmeNbRWzmi c5zNIVfhU5KqIGXHIsJ8yRohX6ZGMa1TTeaW3wgP8QvrHNfpffiBDYkI6yL6pAd8 383GewLGDu9DdaEDVKs0n3MprYGeS6cp5unWw8UkUH3vCY6SPQhf3HiKMPUO5lLo 17VPZrQb3jAfdzDEHUNBtqdqjLJ6/JbR6sgYu6/+r/CCceWqydObY3+UN7ZW9KDg 97+hZR+W9msQjSh6xBsoTQukHIu4jldm8uM0Q4JuiHhd0rawjj0= =uVOv -----END PGP SIGNATURE----- --j9HmnOu4/O3b3U8i--